Bug 105288 - [EFL] ImageDiff does not build on WebKit2 only builds
Summary: [EFL] ImageDiff does not build on WebKit2 only builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thiago Marcos P. Santos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-18 07:12 PST by Thiago Marcos P. Santos
Modified: 2012-12-18 07:50 PST (History)
6 users (show)

See Also:


Attachments
Patch (29.50 KB, patch)
2012-12-18 07:16 PST, Thiago Marcos P. Santos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Marcos P. Santos 2012-12-18 07:12:57 PST
The tool lives inside DumpRenderTree (although it doesn't depend on it). It also link with tons of unnecessary libraries for no apparent reason.

We should move it to a neutral place and enable it by default regardless of what version of the WebKit API you are building.
Comment 1 Thiago Marcos P. Santos 2012-12-18 07:16:35 PST
Created attachment 179936 [details]
Patch
Comment 2 Laszlo Gombos 2012-12-18 07:34:14 PST
I would move the ImageDiff directory at the same level as DumpRenderTree - e.g. Tools/ImageDiff(/efl). We should probably check with other ports for their preference for the location.
Comment 3 WebKit Review Bot 2012-12-18 07:50:31 PST
Comment on attachment 179936 [details]
Patch

Clearing flags on attachment: 179936

Committed r138019: <http://trac.webkit.org/changeset/138019>
Comment 4 WebKit Review Bot 2012-12-18 07:50:36 PST
All reviewed patches have been landed.  Closing bug.