Currently, we don't have any way to determine if EGL is supported by the build. We probably would need something like FindEGL.cmake unless something is already included in cmake distributions.
Created attachment 179939 [details] patch
Comment on attachment 179939 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=179939&action=review I'm fine on landing a FindSomething without actually using it if the is a imminent use case. > ChangeLog:4 > + [EFL] Allow the build system to detect EGL support. > + https://bugs.webkit.org/show_bug.cgi?id=105287. Nit, we don't use dots at the end here. > Source/cmake/FindEGL.cmake:36 > + > +include(FindPackageHandleStandardArgs) Where is the FIND_PACKAGE_HANDLE_STANDARD_ARGS?
(In reply to comment #2) > (From update of attachment 179939 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=179939&action=review > > I'm fine on landing a FindSomething without actually using it if the is a imminent use case. > > > ChangeLog:4 > > + [EFL] Allow the build system to detect EGL support. > > + https://bugs.webkit.org/show_bug.cgi?id=105287. > > Nit, we don't use dots at the end here. > > > Source/cmake/FindEGL.cmake:36 > > + > > +include(FindPackageHandleStandardArgs) > > Where is the FIND_PACKAGE_HANDLE_STANDARD_ARGS? Sorry, the FIND_PACKAGE_HANDLE_STANDARD_ARGS was cropped from my "review window" somehow. But it should be uppercase because is a macro, not a built-in cmake command.
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 179939 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=179939&action=review > > > > I'm fine on landing a FindSomething without actually using it if the is a imminent use case. > > > > > ChangeLog:4 > > > + [EFL] Allow the build system to detect EGL support. > > > + https://bugs.webkit.org/show_bug.cgi?id=105287. > > > > Nit, we don't use dots at the end here. > > > > > Source/cmake/FindEGL.cmake:36 > > > + > > > +include(FindPackageHandleStandardArgs) > > > > Where is the FIND_PACKAGE_HANDLE_STANDARD_ARGS? > > Sorry, the FIND_PACKAGE_HANDLE_STANDARD_ARGS was cropped from my "review window" somehow. But it should be uppercase because is a macro, not a built-in cmake command. The order of the parameters of the FIND_PACKAGE_HANDLE_STANDARD_ARGS is also wrong.
Created attachment 179954 [details] reviewpatch After our discussion, we agree that the order doesn't matter.
Comment on attachment 179954 [details] reviewpatch lgtm.
Comment on attachment 179954 [details] reviewpatch Clearing flags on attachment: 179954 Committed r138033: <http://trac.webkit.org/changeset/138033>
All reviewed patches have been landed. Closing bug.