Bug 105278 – Web Inspector: add async API for passing renderer process memory stats

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Alexei Filippov]

On some platforms (e.g. Linux) it may take some time to collect total process memory information as it involves an IPC out of a sandboxed renderer process. So add an async way to collect the statistics.

[Alexei Filippov]

Created attachment 179923 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Darin Fisher (:fishd, Google)]

Comment on attachment 179923 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179923&action=review

> Source/Platform/chromium/public/Platform.h:78
> +class ProcessMemorySizesCallback {

nit: each top-level class / struct / enum should have its own header file.

[Alexei Filippov]

Created attachment 180192 [details]
Patch

[Alexei Filippov]

Comment on attachment 179923 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179923&action=review

>> Source/Platform/chromium/public/Platform.h:78
>> +class ProcessMemorySizesCallback {
> 
> nit: each top-level class / struct / enum should have its own header file.

Thanks! Moved it inside Platform. Don't think it makes sense to have a separate file here.

[Early Warning System Bot]

Comment on attachment 180192 [details]
Patch

Attachment 180192 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/15413725

[Early Warning System Bot]

Comment on attachment 180192 [details]
Patch

Attachment 180192 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15400757

[Build Bot]

Comment on attachment 180192 [details]
Patch

Attachment 180192 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15412752

New failing tests:
fast/frames/sandboxed-iframe-attribute-parsing.html

[Alexei Filippov]

Created attachment 180325 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 180325 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180325&action=review

> Source/Platform/chromium/public/Platform.h:223
> +    // memory currently allocated to this process that cannot be shared.

You should describe whether the ownership of the callback is passed to the callee.

[Alexei Filippov]

Created attachment 180668 [details]
Patch

[Alexei Filippov]

Comment on attachment 180325 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180325&action=review

>> Source/Platform/chromium/public/Platform.h:223
>> +    // memory currently allocated to this process that cannot be shared.
> 
> You should describe whether the ownership of the callback is passed to the callee.

done.

[WebKit Review Bot]

Comment on attachment 180668 [details]
Patch

Clearing flags on attachment: 180668

Committed r138450: <http://trac.webkit.org/changeset/138450>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.