Now that we've added --profile option to run-perf-tests, do we still need --pause-before-testing? We added this option to help us attach profiler but it adds a lot of crafts to various parts in webkitpy.
Completely up to you. :)
(In reply to comment #1) > Completely up to you. :) Alright. Let's get rid of it. I'm planning to make a serious of improvements to run-perf-tests and not having to support it will considerably simplify the patch.
I would caution you that --profile is not currently designed to handle every possible iprofiler, etc. configuration, so if others are using --pause-before-testing for more exciting profiling, it may still have its uses.
(In reply to comment #3) > I would caution you that --profile is not currently designed to handle every possible iprofiler, etc. configuration, so if others are using --pause-before-testing for more exciting profiling, it may still have its uses. I guess we can always restore it if someone complaints.
Created attachment 179882 [details] Cleanup
Comment on attachment 179882 [details] Cleanup I believe you can also remove Driver.start() as dpranke told me once it only existed for this option to perf-tests.
(In reply to comment #6) > (From update of attachment 179882 [details]) > I believe you can also remove Driver.start() as dpranke told me once it only existed for this option to perf-tests. Will do.
Created attachment 179883 [details] Also remove Driver.start
Comment on attachment 179883 [details] Also remove Driver.start This looks fine to me, but you should probably also have dpranke take a look, and probably give folks at least until tomorrow to give comments (since you announced it on webkit-dev). :)
Comment on attachment 179883 [details] Also remove Driver.start Clearing flags on attachment: 179883 Committed r138042: <http://trac.webkit.org/changeset/138042>
All reviewed patches have been landed. Closing bug.