Bug 105245 - Allow position:sticky elements to be moved by the scrolling thread
Summary: Allow position:sticky elements to be moved by the scrolling thread
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks: 104276
  Show dependency tree / graph
 
Reported: 2012-12-17 20:13 PST by Simon Fraser (smfr)
Modified: 2013-01-15 14:52 PST (History)
11 users (show)

See Also:

Attachments
Patch (53.22 KB, patch)
2012-12-17 20:25 PST, Simon Fraser (smfr) 		bdakin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2012-12-17 20:13:44 PST 
Allow position:sticky elements to be moved by the scrolling thread
Comment 1 Simon Fraser (smfr) 2012-12-17 20:25:56 PST 
Created attachment 179870 [details]
Patch
Comment 2 Alexey Proskuryakov 2012-12-18 10:09:32 PST 
Simon says that this will mostly fix bug 104276.
Comment 3 Beth Dakin 2012-12-18 12:16:12 PST 
Comment on attachment 179870 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179870&action=review

It seems like there should be a way to share a little more code between ScrollingStateFixedNode/ScrollingStateStickyNode and ScrollingTreeFixedNode/ScrollingTreeStickyNode, but I think this is fine for now.

> Source/WebCore/rendering/RenderLayerCompositor.cpp:2723
> +    if (m_renderView->document()->ownerElement())

You should fix the comment here. It still claims that we don't yet support sticky.
Comment 4 Simon Fraser (smfr) 2012-12-18 15:33:16 PST 
http://trac.webkit.org/changeset/138076
Comment 5 Ryosuke Niwa 2012-12-20 12:39:06 PST 
This patch appears to have caused test failures on WK2 bots:
e.g.
http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r138276%20(4305)/results.html