Bug 105242 – [Shadow] LargeDistributionWithLayout.html should be updated

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Shinya Kawanaka]

This test was written when distribution was O(N^2). Now it's almost O(N), this test should have more loops.

[Shinya Kawanaka]

Created attachment 179864 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 179864 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179864&action=review

> PerformanceTests/ChangeLog:9
> +        Since this test was written when distribution took O(N^2). However, now it's almost O(N), so this test finishes
> +        in very short time. Also, this test contains a some error to cause test failure, it also should be fixed.

We should use run/s in this test instead.

[Shinya Kawanaka]

Created attachment 179875 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 179875 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179875&action=review

> PerformanceTests/ShadowDOM/LargeDistributionWithLayout.html:26
> +    window.content = document.createElement('content');

Why don't we just declare this variable outside of the function? So this test wasn't doing anything useful before?

> PerformanceTests/ShadowDOM/LargeDistributionWithLayout.html:27
> +    window.shadowRoot = host.webkitCreateShadowRoot();

I don't think we need to expose this variable. It's not used elsewhere.

[Shinya Kawanaka]

> Why don't we just declare this variable outside of the function? So this test wasn't doing anything useful before?

Unfortunately it is true... It's my fault. Maybe I wrongly uploaded a bit old version and it's committed...
Basically this test and all tests in ShadowDOM/ are off by default, but they're used in our environment to track ShadowDOM performance.

[Shinya Kawanaka]

Created attachment 179880 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 179880 [details]
Patch for landing

Clearing flags on attachment: 179880

Committed r137990: <http://trac.webkit.org/changeset/137990>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.