Bug 105238 – [chromium] Add the GL_CHROMIUM_lose_context to WebGraphicsContext3D

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dana Jansens]

[chromium] Add the GL_CHROMIUM_lose_context to WebGraphicsContext3D

[Dana Jansens]

Created attachment 179846 [details]
Patch

[James Robinson]

Comment on attachment 179846 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179846&action=review

> Source/Platform/chromium/public/WebGraphicsContext3D.h:244
> +    virtual void loseContext() { }

can we call it lostContextCHROMIUM() to be consistent with the naming for other extensions?

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Dana Jansens]

Created attachment 179847 [details]
Patch for landing

[Dana Jansens]

(In reply to comment #2)
> (From update of attachment 179846 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=179846&action=review
> 
> > Source/Platform/chromium/public/WebGraphicsContext3D.h:244
> > +    virtual void loseContext() { }
> 
> can we call it lostContextCHROMIUM() to be consistent with the naming for other extensions?

Oops, definitely.

[Dana Jansens]

Comment on attachment 179847 [details]
Patch for landing

Maybe these lost context tests are useless now.

[Dana Jansens]

Committed r137970: <http://trac.webkit.org/changeset/137970>