Bug 105238 - [chromium] Add the GL_CHROMIUM_lose_context to WebGraphicsContext3D
Summary: [chromium] Add the GL_CHROMIUM_lose_context to WebGraphicsContext3D
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Jansens
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-17 18:22 PST by Dana Jansens
Modified: 2012-12-17 19:32 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.47 KB, patch)
2012-12-17 18:22 PST, Dana Jansens 		no flags Details | Formatted Diff | Diff
Patch for landing (1.51 KB, patch)
2012-12-17 18:27 PST, Dana Jansens 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2012-12-17 18:22:02 PST 
[chromium] Add the GL_CHROMIUM_lose_context to WebGraphicsContext3D
Comment 1 Dana Jansens 2012-12-17 18:22:17 PST 
Created attachment 179846 [details]
Patch
Comment 2 James Robinson 2012-12-17 18:23:59 PST 
Comment on attachment 179846 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179846&action=review

> Source/Platform/chromium/public/WebGraphicsContext3D.h:244
> +    virtual void loseContext() { }

can we call it lostContextCHROMIUM() to be consistent with the naming for other extensions?
Comment 3 WebKit Review Bot 2012-12-17 18:24:04 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Dana Jansens 2012-12-17 18:27:57 PST 
Created attachment 179847 [details]
Patch for landing
Comment 5 Dana Jansens 2012-12-17 18:28:07 PST 
(In reply to comment #2)
> (From update of attachment 179846 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=179846&action=review
> 
> > Source/Platform/chromium/public/WebGraphicsContext3D.h:244
> > +    virtual void loseContext() { }
> 
> can we call it lostContextCHROMIUM() to be consistent with the naming for other extensions?

Oops, definitely.
Comment 6 Dana Jansens 2012-12-17 19:06:53 PST 
Comment on attachment 179847 [details]
Patch for landing

Maybe these lost context tests are useless now.
Comment 7 Dana Jansens 2012-12-17 19:32:06 PST 
Committed r137970: <http://trac.webkit.org/changeset/137970>