Bug 105237 - DFG: Refactor DFGCorrectableJumpPoint to reduce size of OSRExit data
Summary: DFG: Refactor DFGCorrectableJumpPoint to reduce size of OSRExit data
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on: 105270
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-17 18:11 PST by Michael Saboff
Modified: 2012-12-18 02:34 PST (History)
4 users (show)

See Also:


Attachments
Patch (31.20 KB, patch)
2012-12-17 18:20 PST, Michael Saboff
fpizlo: review+
msaboff: commit-queue-
Details | Formatted Diff | Diff
Patch with change in CMakeLists.txt missed in first patch (31.72 KB, patch)
2012-12-17 18:29 PST, Michael Saboff
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Added reviewer information. (31.72 KB, patch)
2012-12-17 18:54 PST, Michael Saboff
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2012-12-17 18:11:32 PST
The DFGCorrectableJumpPoint class contains information used during DFG compilation (the failure case Jump) phase as well as during code execution (offset to the patchable jump).  These objects are part of the code block, one per OSRExit, therefore it makes sense to eliminate the information needed during compilation.

DFGCorrectableJumpPoint should be refactored and effectively split.
Comment 1 Michael Saboff 2012-12-17 18:20:57 PST
Created attachment 179845 [details]
Patch
Comment 2 Michael Saboff 2012-12-17 18:29:16 PST
Created attachment 179848 [details]
Patch with change in CMakeLists.txt missed in first patch
Comment 3 WebKit Review Bot 2012-12-17 18:42:07 PST
Comment on attachment 179848 [details]
Patch with change in CMakeLists.txt missed in first patch

Rejecting attachment 179848 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

/mnt/git/webkit-commit-queue/Source/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/15355987
Comment 4 Michael Saboff 2012-12-17 18:54:02 PST
Created attachment 179856 [details]
Added reviewer information.
Comment 5 WebKit Review Bot 2012-12-17 19:52:12 PST
Comment on attachment 179856 [details]
Added reviewer information.

Clearing flags on attachment: 179856

Committed r137976: <http://trac.webkit.org/changeset/137976>
Comment 6 WebKit Review Bot 2012-12-17 19:52:17 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Csaba Osztrogonác 2012-12-18 02:34:27 PST
(In reply to comment #5)
> (From update of attachment 179856 [details])
> Clearing flags on attachment: 179856
> 
> Committed r137976: <http://trac.webkit.org/changeset/137976>

It broke the ARMv7 build - see https://bugs.webkit.org/show_bug.cgi?id=105270 for details.