Bug 105236 - run-perf-tests should warn (loudly) if you're using a Debug build
Summary: run-perf-tests should warn (loudly) if you're using a Debug build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-17 18:00 PST by Eric Seidel (no email)
Modified: 2013-11-14 07:36 PST (History)
6 users (show)

See Also:


Attachments
Patch (2.01 KB, patch)
2013-11-14 04:10 PST, Éva Balázsfalvi
no flags Details | Formatted Diff | Diff
Patch (1.55 KB, patch)
2013-11-14 06:56 PST, Éva Balázsfalvi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2012-12-17 18:00:23 PST
run-perf-tests should warn (loudly) if you're using a Debug build

Trying to get perf numbers out of a Debug build is folly.  Sure, we can support people running with run-perf-tests --debug, but we should scream at them to make sure the innocent bystanders don't get confused by their checkout being in --debug mode (set-webkit-configuration --debug) and run-perf-tests giving them debug numbers.  pdr was bitten by this earlier today.
Comment 1 Éva Balázsfalvi 2013-11-14 04:10:53 PST
Created attachment 216916 [details]
Patch
Comment 2 Csaba Osztrogonác 2013-11-14 04:30:04 PST
Comment on attachment 216916 [details]
Patch

The idea is good, but this patch has an issue: I get this warning too if the default 
configuration is Debug, but I passed --relase as command line argument.
Comment 3 Éva Balázsfalvi 2013-11-14 06:56:41 PST
Created attachment 216929 [details]
Patch
Comment 4 Csaba Osztrogonác 2013-11-14 07:10:34 PST
Comment on attachment 216929 [details]
Patch

It sounds much more better, r=me.
Comment 5 WebKit Commit Bot 2013-11-14 07:36:01 PST
Comment on attachment 216929 [details]
Patch

Clearing flags on attachment: 216929

Committed r159285: <http://trac.webkit.org/changeset/159285>
Comment 6 WebKit Commit Bot 2013-11-14 07:36:03 PST
All reviewed patches have been landed.  Closing bug.