RESOLVED FIXED 105233
Track menu needs localization 
https://bugs.webkit.org/show_bug.cgi?id=105233
Summary Track menu needs localization
Dean Jackson
Reported 2012-12-17 17:37:19 PST
The static text labels in the track menu need to be localizable.
Attachments
Patch (18.44 KB, patch)
2012-12-18 13:28 PST, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (18.43 KB, patch)
2012-12-18 13:59 PST, Dean Jackson 		eric.carlson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2012-12-17 17:37:59 PST
<rdar://problem/12898144>
Dean Jackson
Comment 2 2012-12-18 13:28:21 PST
Created attachment 180015 [details] Patch
Dean Jackson
Comment 3 2012-12-18 13:59:03 PST
Created attachment 180018 [details] Patch
Dean Jackson
Comment 4 2012-12-18 14:34:18 PST
Committed r138071: <http://trac.webkit.org/changeset/138071>
Adam Klein
Comment 5 2012-12-18 16:00:40 PST
+cr-ews owners: what's up with the cr-linux EWS jobs on this bug? They claim to have passed but this patch has linking errors on all Chromium ports.
Dean Jackson
Comment 6 2012-12-18 16:08:56 PST
Silvia, HEADS UP. If Chromium enables this code, you'll have to update my build-fix in r138079 I made all the strings empty for Chromium. There was some discussion on IRC about where the LocalizedStrings.cpp file for Chromium should be.
Silvia Pfeiffer
Comment 7 2012-12-28 12:07:04 PST
OK. Adding Victor to this, too, to make sure we don't forget.
Note You need to log in before you can comment on or make changes to this bug.