Bug 105221 - Butterfly::growArrayRight shouldn't be called on null Butterfly objects
Summary: Butterfly::growArrayRight shouldn't be called on null Butterfly objects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-17 15:26 PST by Mark Hahnenberg
Modified: 2012-12-17 17:05 PST (History)
1 user (show)

See Also:

Attachments
Patch (4.60 KB, patch)
2012-12-17 16:00 PST, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Patch (4.58 KB, patch)
2012-12-17 16:53 PST, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2012-12-17 15:26:20 PST 
Currently we depend upon the fact that Butterfly::growArrayRight works with null Butterfly objects purely by coincidence. We should add a new static function that null checks the old Butterfly object and creates a new one if it's null, or calls growArrayRight if it isn't for use in the couple of places in JSObject that expect such behavior to work.
Comment 1 Mark Hahnenberg 2012-12-17 16:00:29 PST 
Created attachment 179821 [details]
Patch
Comment 2 Early Warning System Bot 2012-12-17 16:07:25 PST 
Comment on attachment 179821 [details]
Patch

Attachment 179821 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/15360953
Comment 3 Early Warning System Bot 2012-12-17 16:08:12 PST 
Comment on attachment 179821 [details]
Patch

Attachment 179821 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15375881
Comment 4 Mark Hahnenberg 2012-12-17 16:53:23 PST 
Created attachment 179834 [details]
Patch
Comment 5 Mark Hahnenberg 2012-12-17 17:04:57 PST 
Committed r137961: <http://trac.webkit.org/changeset/137961>