Bug 105213 - REGRESSION(r136324): flex items with percent heights not resizing
Summary: REGRESSION(r136324): flex items with percent heights not resizing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-17 13:31 PST by Tony Chang
Modified: 2012-12-18 10:24 PST (History)
4 users (show)

See Also:

Attachments
Patch (14.17 KB, patch)
2012-12-17 13:35 PST, Tony Chang 		no flags Details | Formatted Diff | Diff
Patch for landing (14.03 KB, patch)
2012-12-18 09:45 PST, Tony Chang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2012-12-17 13:31:45 PST 
REGRESSION(r136324): flex items with percent heights not resizing
Comment 1 Tony Chang 2012-12-17 13:35:07 PST 
Created attachment 179794 [details]
Patch
Comment 2 Ojan Vafai 2012-12-17 20:49:41 PST 
Comment on attachment 179794 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179794&action=review

Up to you on the naming. Figured I'd at least try to make a suggestion. :)

> Source/WebCore/rendering/RenderBlock.h:531
> +    void updateNeedsLayoutAndPreferredLogicalWidthsDirtyBeforeBlockChildLayout(bool relayoutChildren, RenderBox* child);

Ugh. This is so verbose. I can't think of anything more concise though. updateDirtyBitsBeforeBlockChildLayout?
Comment 3 Tony Chang 2012-12-18 09:45:22 PST 
Created attachment 179966 [details]
Patch for landing
Comment 4 Tony Chang 2012-12-18 09:45:55 PST 
Comment on attachment 179794 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179794&action=review

>> Source/WebCore/rendering/RenderBlock.h:531
>> +    void updateNeedsLayoutAndPreferredLogicalWidthsDirtyBeforeBlockChildLayout(bool relayoutChildren, RenderBox* child);
> 
> Ugh. This is so verbose. I can't think of anything more concise though. updateDirtyBitsBeforeBlockChildLayout?

I went with updateBlockChildDirtyBitsBeforeLayout
Comment 5 WebKit Review Bot 2012-12-18 10:24:20 PST 
Comment on attachment 179966 [details]
Patch for landing

Clearing flags on attachment: 179966

Committed r138037: <http://trac.webkit.org/changeset/138037>
Comment 6 WebKit Review Bot 2012-12-18 10:24:24 PST 
All reviewed patches have been landed.  Closing bug.