Bug 105208 - [CSS Exclusions] Differentiate names in the simple rectangle test script
Summary: [CSS Exclusions] Differentiate names in the simple rectangle test script
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Niklas Q Nielsen
URL:
Keywords:
Depends on: 104582
Blocks: 89256
  Show dependency tree / graph
 
Reported: 2012-12-17 13:17 PST by Bear Travis
Modified: 2013-08-28 10:10 PDT (History)
1 user (show)

See Also:

Attachments
Rename createRectangleTest and createRectangleTestResult to testRectangle and expectRectangle respectively (14.79 KB, patch)
2013-08-22 13:49 PDT, Niklas Q Nielsen 		no flags Details | Formatted Diff | Diff
Rename createRectangleTest and createRectangleTestResult to drawTestRectangle and drawExpectRectangle respectively. (14.91 KB, patch)
2013-08-22 17:28 PDT, Niklas Q Nielsen 		no flags Details | Formatted Diff | Diff
Rename createRectangleTest and createRectangleTestResult to drawTestRectangle and drawExpectedRectangle respectively. (14.86 KB, patch)
2013-08-26 11:21 PDT, Niklas Q Nielsen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bear Travis 2012-12-17 13:17:05 PST 
createRectangleTest and createRectangleTestResult have similar names, which may lead to misuse.
Find a way to differentiate them more clearly.
Comment 1 Niklas Q Nielsen 2013-08-22 13:49:56 PDT 
Created attachment 209389 [details]
Rename createRectangleTest and createRectangleTestResult to testRectangle and expectRectangle respectively
Comment 2 Niklas Q Nielsen 2013-08-22 17:28:16 PDT 
Created attachment 209412 [details]
Rename createRectangleTest and createRectangleTestResult to drawTestRectangle and drawExpectRectangle respectively.
Comment 3 Niklas Q Nielsen 2013-08-26 11:21:31 PDT 
Created attachment 209665 [details]
Rename createRectangleTest and createRectangleTestResult to drawTestRectangle and drawExpectedRectangle respectively.
Comment 4 Alexandru Chiculita 2013-08-28 09:52:36 PDT 
Comment on attachment 209665 [details]
Rename createRectangleTest and createRectangleTestResult to drawTestRectangle and drawExpectedRectangle respectively.

Looks good. Thanks!
Comment 5 WebKit Commit Bot 2013-08-28 10:10:38 PDT 
Comment on attachment 209665 [details]
Rename createRectangleTest and createRectangleTestResult to drawTestRectangle and drawExpectedRectangle respectively.

Clearing flags on attachment: 209665

Committed r154757: <http://trac.webkit.org/changeset/154757>
Comment 6 WebKit Commit Bot 2013-08-28 10:10:41 PDT 
All reviewed patches have been landed.  Closing bug.