Bug 105199 - [BlackBerry] Restructure the render queue to process multiple tiles at once
Summary: [BlackBerry] Restructure the render queue to process multiple tiles at once
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jakob Petsovits
URL:
Keywords:
Depends on:
Blocks: 105302
  Show dependency treegraph
 
Reported: 2012-12-17 11:44 PST by Jakob Petsovits
Modified: 2012-12-18 13:45 PST (History)
8 users (show)

See Also:


Attachments
Patch (110.32 KB, patch)
2012-12-18 08:01 PST, Jakob Petsovits
no flags Details | Formatted Diff | Diff
Build fix (1.85 KB, patch)
2012-12-18 13:15 PST, Jakob Petsovits
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jakob Petsovits 2012-12-17 11:44:52 PST
Since my last big commit, r136442, the BackingStore's render() function is able to fetch multiple back buffers and swap them into the user interface thread in one go. However, it turns out that this is not enough to actually render to all of the available back buffers at once. So we block more and don't really take good advantage of having multiple back buffers available.

We should do whatever's necessary to actually make use of this feature. In the words of our co-op Bryan, "Faster Power!". Patch below. (Waiting for Arvid to finish his internal review so I can credit him in the commit message.)
Comment 1 Jakob Petsovits 2012-12-18 08:01:36 PST
Created attachment 179942 [details]
Patch
Comment 2 WebKit Review Bot 2012-12-18 08:38:23 PST
Comment on attachment 179942 [details]
Patch

Clearing flags on attachment: 179942

Committed r138024: <http://trac.webkit.org/changeset/138024>
Comment 3 WebKit Review Bot 2012-12-18 08:38:26 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Jakob Petsovits 2012-12-18 13:04:14 PST
Apparently I fail at merge conflict resolution. Upstream has bdakin's LayoutMilestones patch which my development branch yet has to pick up, it indented a block in FrameLoaderClientBlackBerry. On resolving the conflict, I replaced blitVisibleTiles() (intended) but failed to delete the clearVisibleTiles() line, resulting in a build error as that function has been removed.

Patch forthcoming, give me a sec.
Comment 5 Jakob Petsovits 2012-12-18 13:15:40 PST
Created attachment 180013 [details]
Build fix
Comment 6 WebKit Review Bot 2012-12-18 13:45:15 PST
Comment on attachment 180013 [details]
Build fix

Clearing flags on attachment: 180013

Committed r138066: <http://trac.webkit.org/changeset/138066>
Comment 7 WebKit Review Bot 2012-12-18 13:45:19 PST
All reviewed patches have been landed.  Closing bug.