Bug 105191 - [GTK][GStreamer] Fullscreen option in video element context menu not working
Summary: [GTK][GStreamer] Fullscreen option in video element context menu not working
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xabier Rodríguez Calvar
URL:
Keywords:
Depends on: 117551
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-17 09:46 PST by Eduardo Lima Mitev
Modified: 2013-06-18 01:19 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.53 KB, patch)
2013-06-14 04:09 PDT, Xabier Rodríguez Calvar
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from APPLE-EWS-3 for win-future (786.47 KB, application/zip)
2013-06-14 15:35 PDT, Build Bot
no flags Details
Patch (4.62 KB, patch)
2013-06-17 06:57 PDT, Xabier Rodríguez Calvar
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eduardo Lima Mitev 2012-12-17 09:46:09 PST
1) run-launcher --gtk --enable-fullscreen=TRUE
2) Open page with video element and movie (i,e: http://chaos.troll.no/~tavestbo/webkit/mediaelement/)
3) Right click player, context menu opens.
4) Select "Switch Video to Fullscreen"

Nothing happens, however the fullscreen button in the controls bar does work.
Same with WebKit 2.
Comment 1 Philippe Normand 2013-04-25 07:59:27 PDT
Is that issue still valid? It'd be nice to fix it for WK2 at least.
Comment 2 Xabier Rodríguez Calvar 2013-05-24 03:22:24 PDT
(In reply to comment #1)
> Is that issue still valid? It'd be nice to fix it for WK2 at least.

Yes, still valid.
Comment 3 Xabier Rodríguez Calvar 2013-06-14 04:09:31 PDT
Created attachment 204697 [details]
Patch

Removed the use of native controls and updated the test expectations.
Comment 4 Xabier Rodríguez Calvar 2013-06-14 10:03:04 PDT
(In reply to comment #3)
> Created an attachment (id=204697) [details]

The crash I added to the expectations disappears when the patch proposed for bug 117551, hence, adding dependency.
Comment 5 Build Bot 2013-06-14 15:35:25 PDT
Comment on attachment 204697 [details]
Patch

Attachment 204697 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/922054

New failing tests:
fast/media/mq-transform-03.html
fast/media/mq-transform-02.html
platform/win/accessibility/multiple-select-element-role.html
Comment 6 Build Bot 2013-06-14 15:35:27 PDT
Created attachment 204739 [details]
Archive of layout-test-results from APPLE-EWS-3 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: APPLE-EWS-3  Port: win-future  Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit
Comment 7 Xabier Rodríguez Calvar 2013-06-14 16:27:38 PDT
(In reply to comment #5)
> New failing tests:
> fast/media/mq-transform-03.html
> fast/media/mq-transform-02.html
> platform/win/accessibility/multiple-select-element-role.html

Is it me or this doesn't make sense according to my patch?
Comment 8 Xabier Rodríguez Calvar 2013-06-17 06:57:40 PDT
Created attachment 204819 [details]
Patch

Removed the use of native controls and updated the test expectations.
Comment 9 Xabier Rodríguez Calvar 2013-06-17 09:16:41 PDT
Comment on attachment 204819 [details]
Patch

Removing cq flag as I cannot watch the bots now.
Comment 10 WebKit Commit Bot 2013-06-18 01:18:58 PDT
Comment on attachment 204819 [details]
Patch

Clearing flags on attachment: 204819

Committed r151674: <http://trac.webkit.org/changeset/151674>
Comment 11 WebKit Commit Bot 2013-06-18 01:19:00 PDT
All reviewed patches have been landed.  Closing bug.