Bug 105191 – [GTK][GStreamer] Fullscreen option in video element context menu not working

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Eduardo Lima Mitev]

1) run-launcher --gtk --enable-fullscreen=TRUE
2) Open page with video element and movie (i,e: http://chaos.troll.no/~tavestbo/webkit/mediaelement/)
3) Right click player, context menu opens.
4) Select "Switch Video to Fullscreen"

Nothing happens, however the fullscreen button in the controls bar does work.
Same with WebKit 2.

[Philippe Normand]

Is that issue still valid? It'd be nice to fix it for WK2 at least.

[Xabier Rodríguez Calvar]

(In reply to comment #1)
> Is that issue still valid? It'd be nice to fix it for WK2 at least.

Yes, still valid.

[Xabier Rodríguez Calvar]

Created attachment 204697 [details]
Patch

Removed the use of native controls and updated the test expectations.

[Xabier Rodríguez Calvar]

(In reply to comment #3)
> Created an attachment (id=204697) [details]

The crash I added to the expectations disappears when the patch proposed for bug 117551, hence, adding dependency.

[Build Bot]

Comment on attachment 204697 [details]
Patch

Attachment 204697 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/922054

New failing tests:
fast/media/mq-transform-03.html
fast/media/mq-transform-02.html
platform/win/accessibility/multiple-select-element-role.html

[Build Bot]

Created attachment 204739 [details]
Archive of layout-test-results from APPLE-EWS-3 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: APPLE-EWS-3  Port: win-future  Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit

[Xabier Rodríguez Calvar]

(In reply to comment #5)
> New failing tests:
> fast/media/mq-transform-03.html
> fast/media/mq-transform-02.html
> platform/win/accessibility/multiple-select-element-role.html

Is it me or this doesn't make sense according to my patch?

[Xabier Rodríguez Calvar]

Created attachment 204819 [details]
Patch

Removed the use of native controls and updated the test expectations.

[Xabier Rodríguez Calvar]

Comment on attachment 204819 [details]
Patch

Removing cq flag as I cannot watch the bots now.

[WebKit Commit Bot]

Comment on attachment 204819 [details]
Patch

Clearing flags on attachment: 204819

Committed r151674: <http://trac.webkit.org/changeset/151674>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.