Bug 105181 - [GStreamer] Use gst_element_link_pads_full() with CHECK_NOTHING for speed and sanity
Summary: [GStreamer] Use gst_element_link_pads_full() with CHECK_NOTHING for speed and...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-17 07:51 PST by Eduardo Lima Mitev
Modified: 2013-02-09 21:04 PST (History)
8 users (show)

See Also:

Attachments
patch (4.17 KB, patch)
2012-12-17 09:17 PST, Eduardo Lima Mitev 		no flags Details | Formatted Diff | Diff
patch update to use '0' instead of 'NULL' (4.17 KB, patch)
2012-12-17 09:28 PST, Eduardo Lima Mitev 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eduardo Lima Mitev 2012-12-17 07:51:31 PST 
There are calls to gst_pad_link() that can be replaced by gst_element_link_pads_full() with GST_PAD_LINK_CHECK_NOTHING flag, preventing unnecessary checks and simplifying code.

Also, getting rid of the gst_element_get_request_pad() calls will ease the migration to Gst 1.0.
Comment 1 Eduardo Lima Mitev 2012-12-17 09:17:28 PST 
Created attachment 179757 [details]
patch

A call to gst_pad_link() in GStreamerGWorld was left untouched because one of the pads is dynamic and is needed after linking; but gst_element_link_pads_full() doesn't give you a reference. Also, that code will not be ported to Gst 1.0 (as philn explained to me).
Comment 2 Eduardo Lima Mitev 2012-12-17 09:28:25 PST 
Created attachment 179759 [details]
patch update to use '0' instead of 'NULL'

previous patch incorrectly had 'NULL' instead of '0' (style checker didn't complain, hmm).
Comment 3 Philippe Normand 2012-12-17 10:58:30 PST 
Comment on attachment 179759 [details]
patch update to use '0' instead of 'NULL'

Thanks!
Comment 4 WebKit Review Bot 2012-12-17 11:22:09 PST 
Comment on attachment 179759 [details]
patch update to use '0' instead of 'NULL'

Clearing flags on attachment: 179759

Committed r137925: <http://trac.webkit.org/changeset/137925>
Comment 5 WebKit Review Bot 2012-12-17 11:22:13 PST 
All reviewed patches have been landed.  Closing bug.