Bug 105175 - [WinCairo] Compile fix.
Summary: [WinCairo] Compile fix.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-17 07:01 PST by peavo
Modified: 2012-12-18 09:31 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.86 KB, patch)
2012-12-17 07:10 PST, peavo 		no flags Details | Formatted Diff | Diff
Patch (1.79 KB, patch)
2012-12-18 05:11 PST, peavo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2012-12-17 07:01:09 PST 
Some checks for USE(ACCELERATED_COMPOSITING) are missing.
Comment 1 peavo 2012-12-17 07:10:40 PST 
Created attachment 179735 [details]
Patch
Comment 2 Simon Fraser (smfr) 2012-12-17 08:58:57 PST 
Comment on attachment 179735 [details]
Patch

I'd prefer to keep #ifdefs out of cross-platform code. In this case I think it's better to to keep canSafelyEstablishAStackingContext() and code that calls it, and #ifdef the impl of needsCompositedScrolling() to always return false.
Comment 3 peavo 2012-12-18 05:11:55 PST 
Created attachment 179925 [details]
Patch
Comment 4 Simon Fraser (smfr) 2012-12-18 08:57:45 PST 
Comment on attachment 179925 [details]
Patch

Much better, thanks!
Comment 5 WebKit Review Bot 2012-12-18 09:31:00 PST 
Comment on attachment 179925 [details]
Patch

Clearing flags on attachment: 179925

Committed r138030: <http://trac.webkit.org/changeset/138030>
Comment 6 WebKit Review Bot 2012-12-18 09:31:04 PST 
All reviewed patches have been landed.  Closing bug.