RESOLVED FIXED 105164
[chromium] move webintent related methods to TestRunner library 
https://bugs.webkit.org/show_bug.cgi?id=105164
Summary [chromium] move webintent related methods to TestRunner library
jochen
Reported 2012-12-17 04:55:52 PST
[chromium] move webintent related methods to TestRunner library
Attachments
Patch (24.49 KB, patch)
2012-12-17 04:56 PST, jochen 		no flags
DetailsFormatted DiffDiff
Patch for landing (23.43 KB, patch)
2012-12-18 00:47 PST, jochen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2012-12-17 04:56:44 PST
Created attachment 179720 [details] Patch
WebKit Review Bot
Comment 2 2012-12-17 04:58:46 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Tony Chang
Comment 3 2012-12-17 09:36:26 PST
Comment on attachment 179720 [details] Patch LGTM
WebKit Review Bot
Comment 4 2012-12-17 22:11:01 PST
Comment on attachment 179720 [details] Patch Rejecting attachment 179720 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: chromium/TestRunner/src/WebTestProxy.cpp patching file Tools/DumpRenderTree/chromium/WebViewHost.cpp Hunk #2 succeeded at 1292 (offset 10 lines). Hunk #3 succeeded at 1376 (offset 10 lines). patching file Tools/DumpRenderTree/chromium/WebViewHost.h Hunk #3 succeeded at 280 (offset 2 lines). Hunk #4 succeeded at 293 (offset 2 lines). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Darin Fish..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15404045
jochen
Comment 5 2012-12-18 00:47:02 PST
Created attachment 179895 [details] Patch for landing
WebKit Review Bot
Comment 6 2012-12-18 01:06:09 PST
Comment on attachment 179895 [details] Patch for landing Clearing flags on attachment: 179895 Committed r137997: <http://trac.webkit.org/changeset/137997>
WebKit Review Bot
Comment 7 2012-12-18 01:06:14 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.