Bug 105159 - [EFL] Add ecore_imf_evas to FindEcore.cmake
Summary: [EFL] Add ecore_imf_evas to FindEcore.cmake
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-17 03:33 PST by Halton Huo
Modified: 2012-12-17 18:41 PST (History)
6 users (show)

See Also:

Attachments
Patch (3.57 KB, patch)
2012-12-17 03:53 PST, Halton Huo 		no flags Details | Formatted Diff | Diff
Patch (2.51 KB, patch)
2012-12-17 16:54 PST, Halton Huo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Halton Huo 2012-12-17 03:33:45 PST 
ecore_imf_evas is a separate library, we should add ecore_imf_evas as well.

$ls WebKit/WebKitBuild/Dependencies/Root/lib64/libecore_imf*.so
WebKit/WebKitBuild/Dependencies/Root/lib64/libecore_imf_evas.so
WebKit/WebKitBuild/Dependencies/Root/lib64/libecore_imf.so
Comment 1 Halton Huo 2012-12-17 03:53:55 PST 
Created attachment 179711 [details]
Patch
Comment 2 Laszlo Gombos 2012-12-17 08:19:26 PST 
Comment on attachment 179711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179711&action=review

Make sense to me, except the WTF changes.

> Source/WTF/wtf/PlatformEfl.cmake:25
> +    ${ECORE_IMF_EVAS_LIBRARIES}

Is this really necessary ? It seems to me that WTF is not using ECORE_IMF_EVAS_LIBRARIES.
Comment 3 Halton Huo 2012-12-17 16:54:07 PST 
Created attachment 179835 [details]
Patch
Comment 4 Laszlo Gombos 2012-12-17 17:31:17 PST 
Comment on attachment 179835 [details]
Patch

r=me.
Comment 5 WebKit Review Bot 2012-12-17 18:40:59 PST 
Comment on attachment 179835 [details]
Patch

Clearing flags on attachment: 179835

Committed r137969: <http://trac.webkit.org/changeset/137969>
Comment 6 WebKit Review Bot 2012-12-17 18:41:04 PST 
All reviewed patches have been landed.  Closing bug.