Bug 105154 - [chromium] Fix methods in TestRunner that directly modify the settings instead of going through WebPreferences
Summary: [chromium] Fix methods in TestRunner that directly modify the settings instea...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-17 01:20 PST by jochen
Modified: 2012-12-17 23:59 PST (History)
6 users (show)

See Also:

Attachments
Patch (10.99 KB, patch)
2012-12-17 01:22 PST, jochen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2012-12-17 01:20:29 PST 
[chromium] Fix methods in TestRunner that directly modify the settings instead of going through WebPreferences
Comment 1 jochen 2012-12-17 01:22:20 PST 
Created attachment 179701 [details]
Patch
Comment 2 WebKit Review Bot 2012-12-17 01:24:46 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Tony Chang 2012-12-17 09:33:07 PST 
Comment on attachment 179701 [details]
Patch

Will these values get reset to defaults?
Comment 4 jochen 2012-12-17 10:39:26 PST 
(In reply to comment #3)
> (From update of attachment 179701 [details])
> Will these values get reset to defaults?

At the end of each test, the WebPreferences::reset() method is invoked and the resulting settings are applied to the WebView - so yes
Comment 5 WebKit Review Bot 2012-12-17 23:59:40 PST 
Comment on attachment 179701 [details]
Patch

Clearing flags on attachment: 179701

Committed r137992: <http://trac.webkit.org/changeset/137992>
Comment 6 WebKit Review Bot 2012-12-17 23:59:44 PST 
All reviewed patches have been landed.  Closing bug.