Bug 105150 - [V8] Improve performance of a conversion from WebKit strings to V8 strings
Summary: [V8] Improve performance of a conversion from WebKit strings to V8 strings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-16 22:39 PST by Kentaro Hara
Modified: 2012-12-16 23:45 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.26 KB, patch)
2012-12-16 23:01 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-12-16 22:39:15 PST 
I implemented v8::Weak(isolate) and v8::Local::New(isolate, ...), which is much faster than v8::Weak() and v8::Local::New(). By using the faster APIs, we can improve performance of a conversion from WebKit strings to V8 strings.
Comment 1 Kentaro Hara 2012-12-16 23:01:58 PST 
Created attachment 179690 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-12-16 23:09:41 PST 
Comment on attachment 179690 [details]
Patch

YES!  I remember discussing these with Dr. Barth long ago.  These are recent API additions to V8, correct?  I suspect there are many other cases which would benefit from passing the isolate along so v8 doesn't have to branch?
Comment 3 WebKit Review Bot 2012-12-16 23:45:22 PST 
Comment on attachment 179690 [details]
Patch

Clearing flags on attachment: 179690

Committed r137881: <http://trac.webkit.org/changeset/137881>
Comment 4 WebKit Review Bot 2012-12-16 23:45:26 PST 
All reviewed patches have been landed.  Closing bug.