RESOLVED FIXED 105150
[V8] Improve performance of a conversion from WebKit strings to V8 strings 
https://bugs.webkit.org/show_bug.cgi?id=105150
Summary [V8] Improve performance of a conversion from WebKit strings to V8 strings
Kentaro Hara
Reported 2012-12-16 22:39:15 PST
I implemented v8::Weak(isolate) and v8::Local::New(isolate, ...), which is much faster than v8::Weak() and v8::Local::New(). By using the faster APIs, we can improve performance of a conversion from WebKit strings to V8 strings.
Attachments
Patch (2.26 KB, patch)
2012-12-16 23:01 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-12-16 23:01:58 PST
Created attachment 179690 [details] Patch
Eric Seidel (no email)
Comment 2 2012-12-16 23:09:41 PST
Comment on attachment 179690 [details] Patch YES! I remember discussing these with Dr. Barth long ago. These are recent API additions to V8, correct? I suspect there are many other cases which would benefit from passing the isolate along so v8 doesn't have to branch?
WebKit Review Bot
Comment 3 2012-12-16 23:45:22 PST
Comment on attachment 179690 [details] Patch Clearing flags on attachment: 179690 Committed r137881: <http://trac.webkit.org/changeset/137881>
WebKit Review Bot
Comment 4 2012-12-16 23:45:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.