RESOLVED INVALID 105145
[BlackBerry] Honor allowed scroll adjustment setting 
https://bugs.webkit.org/show_bug.cgi?id=105145
Summary [BlackBerry] Honor allowed scroll adjustment setting
Arvid Nilsson
Reported 2012-12-16 18:07:04 PST
This setting is used in various places to determine the allowed scroll/zoom adjustment to ensure text caret or selected text is visible, but not in this place. Add a check for the setting.
Attachments
Patch (1.99 KB, patch)
2012-12-16 18:10 PST, Arvid Nilsson 		no flags
DetailsFormatted DiffDiff
Patch (1.99 KB, patch)
2012-12-16 23:56 PST, Arvid Nilsson 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Arvid Nilsson
Comment 1 2012-12-16 18:10:47 PST
Created attachment 179675 [details] Patch
Arvid Nilsson
Comment 2 2012-12-16 23:56:31 PST
Created attachment 179695 [details] Patch
Arvid Nilsson
Comment 3 2012-12-16 23:57:36 PST
CC George, let's see if cq+ works, otherwise I'll set it back to r?
WebKit Review Bot
Comment 4 2012-12-17 00:02:14 PST
Comment on attachment 179695 [details] Patch Rejecting attachment 179695 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: cwd: /mnt/git/webkit-commit-queue Parsed 2 diffs from patch file(s). patching file Source/WebKit/blackberry/ChangeLog Hunk #1 succeeded at 1 with fuzz 1. patching file Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp Hunk #1 FAILED at 652. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15372625
Arvid Nilsson
Comment 5 2012-12-17 00:41:26 PST
Aha, this seems to be not upstreamable atm.
Arvid Nilsson
Comment 6 2012-12-17 00:41:41 PST
Comment on attachment 179695 [details] Patch Obsolete this patch for now
Note You need to log in before you can comment on or make changes to this bug.