Bug 105143 – [BlackBerry] Adapt to new BlackBerry::Platform::TouchPoint API

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Arvid Nilsson]

Among other changes, TouchPoint instances now provide document coordinates for the viewport and content position of the touch event.

[Arvid Nilsson]

Created attachment 179674 [details]
Patch

[Arvid Nilsson]

Comment on attachment 179674 [details]
Patch

Already reviewed by George

[WebKit Review Bot]

Comment on attachment 179674 [details]
Patch

Rejecting attachment 179674 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
port/TouchEventHandler.cpp.rej
patching file Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.h
Hunk #1 FAILED at 35.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.h.rej
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/DumpRenderTree/blackberry/EventSender.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/15360615

[Arvid Nilsson]

Created attachment 179679 [details]
Patch

[Arvid Nilsson]

Comment on attachment 179679 [details]
Patch

Fixed merge problem

[WebKit Review Bot]

Comment on attachment 179679 [details]
Patch

Rejecting attachment 179679 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 13196 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
52>At revision 13196.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/15363603

[Rob Buis]

Comment on attachment 179679 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179679&action=review

AFAICS no r+ was given before, so this can't work. I'll try r+ now but because the reviewer is already filled in it may fail....

> Source/WebCore/ChangeLog:3
> +        Adapt to new BlackBerry::Platform::TouchPoint API

Would have been better to use [BlackBerry] in the title.

[Arvid Nilsson]

(In reply to comment #7)
> (From update of attachment 179679 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=179679&action=review
> 
> AFAICS no r+ was given before, so this can't work. I'll try r+ now but because the reviewer is already filled in it may fail....
> 
> > Source/WebCore/ChangeLog:3
> > +        Adapt to new BlackBerry::Platform::TouchPoint API
> 
> Would have been better to use [BlackBerry] in the title.

I have successfully cq+'d patches in the past, when they didn't contain an OOPS!, but maybe there was already a previous review to carry over back then.

I'll fix the title of the bug and patch

[Arvid Nilsson]

Created attachment 179691 [details]
Patch

[Arvid Nilsson]

Comment on attachment 179691 [details]
Patch

Let's try this then: "Already reviewed by Rob" =D

[WebKit Review Bot]

Comment on attachment 179691 [details]
Patch

Clearing flags on attachment: 179691

Committed r137880: <http://trac.webkit.org/changeset/137880>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.