Bug 105138 - When the usergesture of mousedown is consumed, mouseup shouldn't have a user gesture indicator
Summary: When the usergesture of mousedown is consumed, mouseup shouldn't have a user ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-16 15:22 PST by jochen
Modified: 2013-01-11 02:09 PST (History)
4 users (show)

See Also:

Attachments
Layout test (2.86 KB, patch)
2013-01-09 14:06 PST, jochen 		no flags Details | Formatted Diff | Diff
Patch (7.50 KB, patch)
2013-01-11 00:21 PST, jochen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2012-12-16 15:22:46 PST 
just came across a pop-under which does the popup creation in mousedown and the hiding in mousedown.

Can probably be fixed by using the same UserGestureIndicator::Token for related events
Comment 1 jochen 2013-01-09 14:06:36 PST 
Created attachment 181979 [details]
Layout test
Comment 2 jochen 2013-01-11 00:21:27 PST 
Created attachment 182278 [details]
Patch
Comment 3 Adam Barth 2013-01-11 01:45:15 PST 
Comment on attachment 182278 [details]
Patch

Nice solution.
Comment 4 WebKit Review Bot 2013-01-11 02:09:13 PST 
Comment on attachment 182278 [details]
Patch

Clearing flags on attachment: 182278

Committed r139419: <http://trac.webkit.org/changeset/139419>
Comment 5 WebKit Review Bot 2013-01-11 02:09:16 PST 
All reviewed patches have been landed.  Closing bug.