Bug 105111 - [BlackBerry] Prevent CookieManager from blocking the WKT thread
Summary: [BlackBerry] Prevent CookieManager from blocking the WKT thread
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-15 14:43 PST by otcheung
Modified: 2012-12-17 13:49 PST (History)
5 users (show)

See Also:

Attachments
Patch (4.33 KB, patch)
2012-12-15 14:50 PST, otcheung 		no flags Details | Formatted Diff | Diff
Patch (3.76 KB, patch)
2012-12-15 14:59 PST, otcheung 		no flags Details | Formatted Diff | Diff
Patch (8.48 KB, patch)
2012-12-17 12:21 PST, otcheung 		no flags Details | Formatted Diff | Diff
Patch (8.09 KB, patch)
2012-12-17 13:24 PST, otcheung 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description otcheung 2012-12-15 14:43:13 PST 
Make the databasebackingstore make the getBackingStoreCookies call to prevent blocking on the WKT thread.
Comment 1 otcheung 2012-12-15 14:50:31 PST 
Created attachment 179620 [details]
Patch
Comment 2 Rob Buis 2012-12-15 14:58:03 PST 
Comment on attachment 179620 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179620&action=review

> Source/WebCore/platform/blackberry/CookieManager.h:107
> +    void getBackingStoreCookies();

Could be just private AFAICS.
Comment 3 otcheung 2012-12-15 14:59:21 PST 
Created attachment 179621 [details]
Patch
Comment 4 Rob Buis 2012-12-15 15:04:27 PST 
Comment on attachment 179621 [details]
Patch

LGTM.
Comment 5 WebKit Review Bot 2012-12-15 15:33:15 PST 
Comment on attachment 179621 [details]
Patch

Clearing flags on attachment: 179621

Committed r137814: <http://trac.webkit.org/changeset/137814>
Comment 6 WebKit Review Bot 2012-12-15 15:33:18 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 otcheung 2012-12-17 12:21:40 PST 
Reopening to attach new patch.
Comment 8 otcheung 2012-12-17 12:21:47 PST 
Created attachment 179779 [details]
Patch
Comment 9 otcheung 2012-12-17 13:24:39 PST 
Created attachment 179790 [details]
Patch
Comment 10 Rob Buis 2012-12-17 13:26:18 PST 
Comment on attachment 179790 [details]
Patch

LGTM.
Comment 11 WebKit Review Bot 2012-12-17 13:49:54 PST 
Comment on attachment 179790 [details]
Patch

Clearing flags on attachment: 179790

Committed r137940: <http://trac.webkit.org/changeset/137940>
Comment 12 WebKit Review Bot 2012-12-17 13:49:57 PST 
All reviewed patches have been landed.  Closing bug.