We are deep copying the struct sent by IMF as they clean up as soon as we return. Free once we're done with it, since we only need the length and location.
Created attachment 179618 [details] Patch
Comment on attachment 179618 [details] Patch LGTM.
Comment on attachment 179618 [details] Patch Rejecting attachment 179618 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: s). patching file Source/WebKit/blackberry/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp Hunk #1 succeeded at 688 (offset -10 lines). Hunk #2 FAILED at 2270. 1 out of 2 hunks FAILED -- saving rejects to file Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15366174
Created attachment 179622 [details] Patch
Comment on attachment 179622 [details] Patch Looks good.
Comment on attachment 179622 [details] Patch Clearing flags on attachment: 179622 Committed r137816: <http://trac.webkit.org/changeset/137816>
All reviewed patches have been landed. Closing bug.