Bug 105098 - Move calculation of caches sizes based on the cache model to CacheModel.h/cpp
Summary: Move calculation of caches sizes based on the cache model to CacheModel.h/cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on: 105152
Blocks:
  Show dependency tree / graph
 
Reported: 2012-12-15 11:43 PST by Sam Weinig
Modified: 2012-12-17 00:08 PST (History)
8 users (show)

See Also:

Attachments
Patch (21.20 KB, patch)
2012-12-15 11:47 PST, Sam Weinig 		andersca: review+
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2012-12-15 11:43:59 PST 
Move calculation of caches sizes based on the cache model to CacheModel.h/cpp
Comment 1 Sam Weinig 2012-12-15 11:47:24 PST 
Created attachment 179603 [details]
Patch
Comment 2 WebKit Review Bot 2012-12-15 11:53:31 PST 
Attachment 179603 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebKit2/Shared/CacheModel.h:37:  The parameter name "cacheModel" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2012-12-15 11:56:50 PST 
Comment on attachment 179603 [details]
Patch

Attachment 179603 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15361187
Comment 4 EFL EWS Bot 2012-12-15 12:08:31 PST 
Comment on attachment 179603 [details]
Patch

Attachment 179603 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/15355171
Comment 5 Sam Weinig 2012-12-15 17:22:40 PST 
http://trac.webkit.org/changeset/137803
Comment 6 Csaba Osztrogonác 2012-12-17 00:08:19 PST 
(In reply to comment #5)
> http://trac.webkit.org/changeset/137803

It broke the Qt Windows build - fix is in https://bugs.webkit.org/show_bug.cgi?id=105152