Bug 105081 – Remove in-band text tracks when media element's src changes

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

All in-band tracks removed from the media element when its src changes.

[Radar WebKit Bug Importer]

<rdar://problem/12887984>

[Eric Carlson]

Created attachment 179576 [details]
Proposed patch

[WebKit Review Bot]

Comment on attachment 179576 [details]
Proposed patch

Attachment 179576 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15317876

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html

[Eric Carlson]

(In reply to comment #3)
> (From update of attachment 179576 [details])
> Attachment 179576 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/15317876
> 
> New failing tests:
> inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html

This is has nothing to do with these change.

[Sam Weinig]

Comment on attachment 179576 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179576&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:2788
> +    beginIgnoringTrackDisplayUpdateRequests();

It might add some point make sense to add an RAII object to use scope to control this bounding.

[WebKit Review Bot]

Comment on attachment 179576 [details]
Proposed patch

Clearing flags on attachment: 179576

Committed r137844: <http://trac.webkit.org/changeset/137844>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.