Bug 105081 - Remove in-band text tracks when media element's src changes
Summary: Remove in-band text tracks when media element's src changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-12-14 18:59 PST by Eric Carlson
Modified: 2012-12-16 11:27 PST (History)
6 users (show)

See Also:

Attachments
Proposed patch (10.03 KB, patch)
2012-12-14 19:12 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2012-12-14 18:59:21 PST 
All in-band tracks removed from the media element when its src changes.
Comment 1 Radar WebKit Bug Importer 2012-12-14 18:59:42 PST 
<rdar://problem/12887984>
Comment 2 Eric Carlson 2012-12-14 19:12:50 PST 
Created attachment 179576 [details]
Proposed patch
Comment 3 WebKit Review Bot 2012-12-14 20:04:55 PST 
Comment on attachment 179576 [details]
Proposed patch

Attachment 179576 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15317876

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Comment 4 Eric Carlson 2012-12-15 08:03:18 PST 
(In reply to comment #3)
> (From update of attachment 179576 [details])
> Attachment 179576 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/15317876
> 
> New failing tests:
> inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html

This is has nothing to do with these change.
Comment 5 Sam Weinig 2012-12-15 18:31:53 PST 
Comment on attachment 179576 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179576&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:2788
> +    beginIgnoringTrackDisplayUpdateRequests();

It might add some point make sense to add an RAII object to use scope to control this bounding.
Comment 6 WebKit Review Bot 2012-12-16 11:27:16 PST 
Comment on attachment 179576 [details]
Proposed patch

Clearing flags on attachment: 179576

Committed r137844: <http://trac.webkit.org/changeset/137844>
Comment 7 WebKit Review Bot 2012-12-16 11:27:20 PST 
All reviewed patches have been landed.  Closing bug.