Bug 105077 - webkitpy: move --lint-test-files code into its own module
Summary: webkitpy: move --lint-test-files code into its own module
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks: 103824 105078
  Show dependency tree / graph
 
Reported: 2012-12-14 18:17 PST by Dirk Pranke
Modified: 2012-12-17 13:51 PST (History)
5 users (show)

See Also:

Attachments
Patch (21.70 KB, patch)
2012-12-14 18:18 PST, Dirk Pranke 		no flags Details | Formatted Diff | Diff
fix main() call in lint-test-expectations (21.72 KB, patch)
2012-12-14 18:22 PST, Dirk Pranke 		eric: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-12-14 18:17:34 PST 
webkitpy: move --lint-test-files code into its own module
Comment 1 Dirk Pranke 2012-12-14 18:18:39 PST 
Created attachment 179569 [details]
Patch
Comment 2 Dirk Pranke 2012-12-14 18:22:59 PST 
Created attachment 179570 [details]
fix main() call in lint-test-expectations
Comment 3 Eric Seidel (no email) 2012-12-14 23:37:59 PST 
Comment on attachment 179570 [details]
fix main() call in lint-test-expectations

View in context: https://bugs.webkit.org/attachment.cgi?id=179570&action=review

Looks like you're mostly moving code.  LGTM.

> Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py:49
> +def lint(host, options, logging_stream):

Eventually we should probably make this a class so we can break it down into smaller helper methods. :)
Comment 4 Dirk Pranke 2012-12-17 13:51:30 PST 
Committed r137942: <http://trac.webkit.org/changeset/137942>