WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
105077
webkitpy: move --lint-test-files code into its own module
https://bugs.webkit.org/show_bug.cgi?id=105077
Summary
webkitpy: move --lint-test-files code into its own module
Dirk Pranke
Reported
2012-12-14 18:17:34 PST
webkitpy: move --lint-test-files code into its own module
Attachments
Patch
(21.70 KB, patch)
2012-12-14 18:18 PST
,
Dirk Pranke
no flags
Details
Formatted Diff
Diff
fix main() call in lint-test-expectations
(21.72 KB, patch)
2012-12-14 18:22 PST
,
Dirk Pranke
eric
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Dirk Pranke
Comment 1
2012-12-14 18:18:39 PST
Created
attachment 179569
[details]
Patch
Dirk Pranke
Comment 2
2012-12-14 18:22:59 PST
Created
attachment 179570
[details]
fix main() call in lint-test-expectations
Eric Seidel (no email)
Comment 3
2012-12-14 23:37:59 PST
Comment on
attachment 179570
[details]
fix main() call in lint-test-expectations View in context:
https://bugs.webkit.org/attachment.cgi?id=179570&action=review
Looks like you're mostly moving code. LGTM.
> Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py:49 > +def lint(host, options, logging_stream):
Eventually we should probably make this a class so we can break it down into smaller helper methods. :)
Dirk Pranke
Comment 4
2012-12-17 13:51:30 PST
Committed
r137942
: <
http://trac.webkit.org/changeset/137942
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug