Bug 105075 – Correct FrameView::scrollableAreaBoundingBox() calculation in the presence of transforms

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tien-Ren Chen]

Correct FrameView::scrollableAreaBoundingBox() calculation

[Tien-Ren Chen]

Created attachment 179564 [details]
Patch

[Tien-Ren Chen]

*** Bug 104730 has been marked as a duplicate of this bug. ***

[Simon Fraser (smfr)]

Comment on attachment 179564 [details]
Patch

Needs a testcase. Does it do the right thing if the frame has border and padding?

[Tien-Ren Chen]

Created attachment 180588 [details]
Patch

[Tien-Ren Chen]

Here is a test case based on Xianzhu's work in 105546.

The border and padding will be included in the non-fast scrollable region, which is a false positive. :(

I will correct that in next upload.

[Tien-Ren Chen]

Created attachment 180589 [details]
Patch

[Build Bot]

Comment on attachment 180589 [details]
Patch

Attachment 180589 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15445720

New failing tests:
scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html
scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html

[WebKit Review Bot]

Comment on attachment 180589 [details]
Patch

Attachment 180589 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15445727

New failing tests:
scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html
scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html

[Simon Fraser (smfr)]

Comment on attachment 180589 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180589&action=review

> Source/WebCore/ChangeLog:3
> +        Correct FrameView::scrollableAreaBoundingBox() calculation

This should say why (... in the presence of transforms).

[Tien-Ren Chen]

Created attachment 181777 [details]
Patch

[Tien-Ren Chen]

Comment on attachment 181777 [details]
Patch

Amended ChangeLog title and rebased.

[Build Bot]

Comment on attachment 181777 [details]
Patch

Attachment 181777 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15774132

New failing tests:
scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html
scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html

[Tien-Ren Chen]

Created attachment 182235 [details]
Patch

[Tien-Ren Chen]

Created attachment 182238 [details]
Patch

[WebKit Review Bot]

Comment on attachment 182238 [details]
Patch

Attachment 182238 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15804165

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html

[Tien-Ren Chen]

(In reply to comment #15)
> (From update of attachment 182238 [details])
> Attachment 182238 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/15804165
> 
> New failing tests:
> inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html

This is a flake. The patch is identical with the last one (except with ChangeLog title amended). PTAL, thanks!

[Tien-Ren Chen]

Ping. Let's get this landed. The included layout test template for non-fast-scrollable region allows us to write many more tests. :)

[WebKit Review Bot]

Comment on attachment 182238 [details]
Patch

Clearing flags on attachment: 182238

Committed r139686: <http://trac.webkit.org/changeset/139686>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.