Bug 105075 - Correct FrameView::scrollableAreaBoundingBox() calculation in the presence of transforms
Summary: Correct FrameView::scrollableAreaBoundingBox() calculation in the presence of...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 104730 (view as bug list)
Depends on: 105546
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-14 17:18 PST by Tien-Ren Chen
Modified: 2013-01-14 16:53 PST (History)
8 users (show)

See Also:


Attachments
Patch (1.66 KB, patch)
2012-12-14 17:21 PST, Tien-Ren Chen
no flags Details | Formatted Diff | Diff
Patch (10.33 KB, patch)
2012-12-21 19:42 PST, Tien-Ren Chen
no flags Details | Formatted Diff | Diff
Patch (10.49 KB, patch)
2012-12-21 19:58 PST, Tien-Ren Chen
no flags Details | Formatted Diff | Diff
Patch (10.52 KB, patch)
2013-01-08 15:04 PST, Tien-Ren Chen
no flags Details | Formatted Diff | Diff
Patch (19.31 KB, patch)
2013-01-10 18:22 PST, Tien-Ren Chen
no flags Details | Formatted Diff | Diff
Patch (19.37 KB, patch)
2013-01-10 18:29 PST, Tien-Ren Chen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tien-Ren Chen 2012-12-14 17:18:26 PST
Correct FrameView::scrollableAreaBoundingBox() calculation
Comment 1 Tien-Ren Chen 2012-12-14 17:21:32 PST
Created attachment 179564 [details]
Patch
Comment 2 Tien-Ren Chen 2012-12-14 17:23:39 PST
*** Bug 104730 has been marked as a duplicate of this bug. ***
Comment 3 Simon Fraser (smfr) 2012-12-15 16:44:16 PST
Comment on attachment 179564 [details]
Patch

Needs a testcase. Does it do the right thing if the frame has border and padding?
Comment 4 Tien-Ren Chen 2012-12-21 19:42:14 PST
Created attachment 180588 [details]
Patch
Comment 5 Tien-Ren Chen 2012-12-21 19:46:11 PST
Here is a test case based on Xianzhu's work in 105546.

The border and padding will be included in the non-fast scrollable region, which is a false positive. :(

I will correct that in next upload.
Comment 6 Tien-Ren Chen 2012-12-21 19:58:45 PST
Created attachment 180589 [details]
Patch
Comment 7 Build Bot 2012-12-21 20:26:18 PST
Comment on attachment 180589 [details]
Patch

Attachment 180589 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15445720

New failing tests:
scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html
scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html
Comment 8 WebKit Review Bot 2012-12-21 20:43:01 PST
Comment on attachment 180589 [details]
Patch

Attachment 180589 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15445727

New failing tests:
scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html
scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html
Comment 9 Simon Fraser (smfr) 2013-01-02 21:39:45 PST
Comment on attachment 180589 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180589&action=review

> Source/WebCore/ChangeLog:3
> +        Correct FrameView::scrollableAreaBoundingBox() calculation

This should say why (... in the presence of transforms).
Comment 10 Tien-Ren Chen 2013-01-08 15:04:37 PST
Created attachment 181777 [details]
Patch
Comment 11 Tien-Ren Chen 2013-01-08 15:05:34 PST
Comment on attachment 181777 [details]
Patch

Amended ChangeLog title and rebased.
Comment 12 Build Bot 2013-01-08 15:42:58 PST
Comment on attachment 181777 [details]
Patch

Attachment 181777 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15774132

New failing tests:
scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html
scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html
Comment 13 Tien-Ren Chen 2013-01-10 18:22:41 PST
Created attachment 182235 [details]
Patch
Comment 14 Tien-Ren Chen 2013-01-10 18:29:21 PST
Created attachment 182238 [details]
Patch
Comment 15 WebKit Review Bot 2013-01-10 19:13:57 PST
Comment on attachment 182238 [details]
Patch

Attachment 182238 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15804165

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Comment 16 Tien-Ren Chen 2013-01-11 15:56:59 PST
(In reply to comment #15)
> (From update of attachment 182238 [details])
> Attachment 182238 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/15804165
> 
> New failing tests:
> inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html

This is a flake. The patch is identical with the last one (except with ChangeLog title amended). PTAL, thanks!
Comment 17 Tien-Ren Chen 2013-01-14 14:42:23 PST
Ping. Let's get this landed. The included layout test template for non-fast-scrollable region allows us to write many more tests. :)
Comment 18 WebKit Review Bot 2013-01-14 16:52:56 PST
Comment on attachment 182238 [details]
Patch

Clearing flags on attachment: 182238

Committed r139686: <http://trac.webkit.org/changeset/139686>
Comment 19 WebKit Review Bot 2013-01-14 16:53:01 PST
All reviewed patches have been landed.  Closing bug.