Bug 105073 – Fix repaint issues when resizing a window with centered content, for platforms with a tile cache

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Simon Fraser (smfr)]

Fix repaint issues when resizing a window with centered content, for platforms with a tile cache

[Simon Fraser (smfr)]

Created attachment 179562 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 179562 [details]
Patch

Will get the bots to chew on the patch before I try to make a test.

[WebKit Review Bot]

Comment on attachment 179562 [details]
Patch

Attachment 179562 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15317840

[Peter Beverloo (cr-android ews)]

Comment on attachment 179562 [details]
Patch

Attachment 179562 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15316921

[Simon Fraser (smfr)]

<rdar://problem/12886441>

[Simon Fraser (smfr)]

Created attachment 179608 [details]
Patch

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/137811

[Thiago Marcos P. Santos]

I'm afraid this patch caused the following assertion the the EFL WK2 Debug bots:

http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug%20WK2/builds/7150

crash log for WebProcess (pid <unknown>):
STDOUT: <empty>
STDERR: ASSERTION FAILED: !paintsIntoCompositedAncestor()
STDERR: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebCore/rendering/RenderLayerBacking.cpp(1561) : void WebCore::RenderLayerBacking::setContentsNeedDisplay()
STDERR: 1   0x7fdcd7696f44 WebCore::RenderLayerBacking::setContentsNeedDisplay()
STDERR: 2   0x7fdcd7691943 WebCore::RenderLayerBacking::updateAfterLayout(unsigned int)
STDERR: 3   0x7fdcd766efaa WebCore::RenderLayer::updateLayerPositions(WebCore::RenderGeometryMap*, unsigned int)
STDERR: 4   0x7fdcd766ef20 WebCore::RenderLayer::updateLayerPositions(WebCore::RenderGeometryMap*, unsigned int)
STDERR: 5   0x7fdcd766ef20 WebCore::RenderLayer::updateLayerPositions(WebCore::RenderGeometryMap*, unsigned int)
STDERR: 6   0x7fdcd766ef20 WebCore::RenderLayer::updateLayerPositions(WebCore::RenderGeometryMap*, unsigned int)
STDERR: 7   0x7fdcd766e9b1 WebCore::RenderLayer::updateLayerPositionsAfterLayout(WebCore::RenderLayer const*, unsigned int)
STDERR: 8   0x7fdcd738cd45 WebCore::FrameView::layout(bool)
STDERR: 9   0x7fdcd6dcf767 WebCore::Document::implicitClose()
STDERR: 10  0x7fdcd727bd57 WebCore::FrameLoader::checkCallImplicitClose()
STDERR: 11  0x7fdcd727badd WebCore::FrameLoader::checkCompleted()
STDERR: 12  0x7fdcd727b8c4 WebCore::FrameLoader::loadDone()
STDERR: 13  0x7fdcd72f9f18 WebCore::CachedResourceLoader::loadDone(WebCore::CachedResource*)
STDERR: 14  0x7fdcd72afb5c WebCore::SubresourceLoader::releaseResources()
STDERR: 15  0x7fdcd72aa550 WebCore::ResourceLoader::didFinishLoading(double)
STDERR: 16  0x7fdcd72af70c WebCore::SubresourceLoader::didFinishLoading(double)
STDERR: 17  0x7fdcd72aacc9 WebCore::ResourceLoader::didFinishLoading(WebCore::ResourceHandle*, double)
STDERR: 18  0x7fdcd7ec2d58
STDERR: 19  0x7fdcd258b775
STDERR: 20  0x7fdcd25a08dd g_simple_async_result_complete
STDERR: 21  0x7fdcd25a0978
STDERR: 22  0x7fdcd28d2e53 g_main_context_dispatch
STDERR: 23  0x7fdcd3fc5a4e
STDERR: 24  0x7fdcd3fbfc29
STDERR: 25  0x7fdcd3fc07b5
STDERR: 26  0x7fdcd3fc0ab7 ecore_main_loop_begin
STDERR: 27  0x7fdcd7e9a9df WebCore::RunLoop::run()
STDERR: 28  0x7fdcdb5e8147 WebProcessMainEfl
STDERR: 29  0x4007f4 main
STDERR: 30  0x7fdcda84f76d __libc_start_main
STDERR: 31  0x400719

[Simon Fraser (smfr)]

I'll take a look.

[Simon Fraser (smfr)]

Assertion will be fixed via bug 105128.