WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
105071
[chromium] Move ownership of WebLayerTreeView to WebWidgetClient
https://bugs.webkit.org/show_bug.cgi?id=105071
Summary
[chromium] Move ownership of WebLayerTreeView to WebWidgetClient
James Robinson
Reported
2012-12-14 16:58:45 PST
[chromium] Move creation of WebLayerTreeView to WebWidgetClient
Attachments
Patch
(4.70 KB, patch)
2012-12-14 17:57 PST
,
James Robinson
no flags
Details
Formatted Diff
Diff
Patch
(8.38 KB, patch)
2012-12-14 18:47 PST
,
James Robinson
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
James Robinson
Comment 1
2012-12-14 17:57:15 PST
Created
attachment 179568
[details]
Patch
James Robinson
Comment 2
2012-12-14 17:58:50 PST
This leaves ownership on the WebViewImpl side, which is a bit weird. In practice we never delete this thing until we destroy the WVI. I'll look at moving the ownership over.
WebKit Review Bot
Comment 3
2012-12-14 18:01:39 PST
Please wait for approval from
abarth@webkit.org
,
dglazkov@chromium.org
,
fishd@chromium.org
,
jamesr@chromium.org
or
tkent@chromium.org
before submitting, as this patch contains changes to the Chromium public API. See also
https://trac.webkit.org/wiki/ChromiumWebKitAPI
.
James Robinson
Comment 4
2012-12-14 18:16:24 PST
Comment on
attachment 179568
[details]
Patch Hmm, I think it's probably going to be easier to move ownership while doing this change which implies some changes to the API.
James Robinson
Comment 5
2012-12-14 18:47:53 PST
Created
attachment 179573
[details]
Patch
James Robinson
Comment 6
2012-12-14 22:41:57 PST
Looks like it'd be fairly easy to move the settings to the other side of the world, since it's just pulling values that come out of WebPreferences.
Adrienne Walker
Comment 7
2012-12-17 10:11:20 PST
Comment on
attachment 179573
[details]
Patch R=me. It's definitely messy, but that's how the two-sided patches have to roll.
WebKit Review Bot
Comment 8
2012-12-17 10:45:49 PST
Comment on
attachment 179573
[details]
Patch Clearing flags on attachment: 179573 Committed
r137921
: <
http://trac.webkit.org/changeset/137921
>
WebKit Review Bot
Comment 9
2012-12-17 10:45:53 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug