Bug 105070 - [Chromium] Restore WebM EME canPlayType() expectations.
Summary: [Chromium] Restore WebM EME canPlayType() expectations.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Dorwin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-14 16:46 PST by David Dorwin
Modified: 2012-12-20 13:16 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.68 KB, patch)
2012-12-14 16:47 PST, David Dorwin
no flags Details | Formatted Diff | Diff
Patch (1.58 KB, patch)
2012-12-19 12:23 PST, David Dorwin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Dorwin 2012-12-14 16:46:44 PST
[Chromium] Restore WebM EME canPlayType() expectations.
Comment 1 David Dorwin 2012-12-14 16:47:45 PST
Created attachment 179558 [details]
Patch
Comment 2 David Dorwin 2012-12-14 16:55:14 PST
Will need cq+ after chromium_rev rolls to 173235 in http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/DEPS.
Comment 3 WebKit Review Bot 2012-12-14 19:46:28 PST
Comment on attachment 179558 [details]
Patch

Attachment 179558 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15311912

New failing tests:
media/encrypted-media/encrypted-media-can-play-type-webm.html
Comment 4 WebKit Review Bot 2012-12-18 14:56:07 PST
Comment on attachment 179558 [details]
Patch

Rejecting attachment 179558 [details] from commit-queue.

New failing tests:
media/encrypted-media/encrypted-media-can-play-type-webm.html
Full output: http://queues.webkit.org/results/15406317
Comment 5 David Dorwin 2012-12-18 16:58:33 PST
Comment on attachment 179558 [details]
Patch

This needs the code to have been built after the DEPS roll, which didn't appear to happen when it ran in the CQ last time.
Comment 6 WebKit Review Bot 2012-12-18 20:06:12 PST
Comment on attachment 179558 [details]
Patch

Rejecting attachment 179558 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
crypto/ppapi/cdm --revision 173055 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
56>At revision 173055.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...
Total errors found: 0 in 0 files

Full output: http://queues.webkit.org/results/15408448
Comment 7 David Dorwin 2012-12-19 12:23:25 PST
Created attachment 180207 [details]
Patch
Comment 8 Tony Chang 2012-12-20 12:43:53 PST
Comment on attachment 180207 [details]
Patch

Test is passing on all the bots.
Comment 9 WebKit Review Bot 2012-12-20 13:16:55 PST
Comment on attachment 180207 [details]
Patch

Clearing flags on attachment: 180207

Committed r138289: <http://trac.webkit.org/changeset/138289>
Comment 10 WebKit Review Bot 2012-12-20 13:16:59 PST
All reviewed patches have been landed.  Closing bug.