Bug 105054 - Use Platform::current() instead of webKitPlatformSupport() in DumpRenderTree
Summary: Use Platform::current() instead of webKitPlatformSupport() in DumpRenderTree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Pilgrim (Google)
URL:
Keywords:
Depends on:
Blocks: 82948
  Show dependency tree / graph
 
Reported: 2012-12-14 14:21 PST by Mark Pilgrim (Google)
Modified: 2012-12-17 11:33 PST (History)
6 users (show)

See Also:

Attachments
Patch (4.23 KB, patch)
2012-12-14 14:21 PST, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
Patch (4.22 KB, patch)
2012-12-17 11:07 PST, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2012-12-14 14:21:16 PST 
Use Platform::current() instead of webKitPlatformSupport() in DumpRenderTree
Comment 1 Mark Pilgrim (Google) 2012-12-14 14:21:47 PST 
Created attachment 179533 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-12-14 14:27:37 PST 
Comment on attachment 179533 [details]
Patch

LGTM.
Comment 3 jochen 2012-12-14 14:29:39 PST 
Comment on attachment 179533 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179533&action=review

> Tools/DumpRenderTree/chromium/NotificationPresenter.cpp:114
> +    WebKit::Platform::current()->callOnMainThread(deferredDisplayDispatch, new WebNotification(notification));

nit. no WebKit:: (here and everywhere)
Comment 4 jochen 2012-12-15 03:08:04 PST 
Comment on attachment 179533 [details]
Patch

Oops, seems I screwed up the flags

Please fix the nits before landing
Comment 5 Mark Pilgrim (Google) 2012-12-17 11:07:32 PST 
Created attachment 179771 [details]
Patch
Comment 6 Mark Pilgrim (Google) 2012-12-17 11:07:51 PST 
Comment on attachment 179771 [details]
Patch

Nits addressed.
Comment 7 Eric Seidel (no email) 2012-12-17 11:10:27 PST 
Comment on attachment 179771 [details]
Patch

LGTM.
Comment 8 WebKit Review Bot 2012-12-17 11:33:31 PST 
Comment on attachment 179771 [details]
Patch

Clearing flags on attachment: 179771

Committed r137926: <http://trac.webkit.org/changeset/137926>
Comment 9 WebKit Review Bot 2012-12-17 11:33:35 PST 
All reviewed patches have been landed.  Closing bug.