Bug 105025 – Add Anton Vayvod and Tim Volodine as contributors in committers.py

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[John Mellor]

Add Anton Vayvod and Tim Volodine to commiters.py

[John Mellor]

Created attachment 179482 [details]
Patch

[Peter Beverloo]

Comment on attachment 179482 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179482&action=review

One thing I'd like you to change (add a reason), happy to set cq+ afterwards.

> Tools/ChangeLog:3
> +        Add Anton Vayvod and Tim Volodine to committers.py

nit: It's clearer to also mention in the title that you're adding them as contributors.

> Tools/ChangeLog:6
> +        Unreviewed. Adds two contributors to committers.py.

Please explain why they should be added. Adding "They contribute to the Text Autosizing feature." would be sufficient already.

[John Mellor]

Created attachment 179734 [details]
Patch

[John Mellor]

Comment on attachment 179482 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179482&action=review

>> Tools/ChangeLog:3
>> +        Add Anton Vayvod and Tim Volodine to committers.py
> 
> nit: It's clearer to also mention in the title that you're adding them as contributors.

Done.

>> Tools/ChangeLog:6
>> +        Unreviewed. Adds two contributors to committers.py.
> 
> Please explain why they should be added. Adding "They contribute to the Text Autosizing feature." would be sufficient already.

Done.

[Peter Beverloo]

Comment on attachment 179734 [details]
Patch

Seems good to me. Thanks John.

[WebKit Review Bot]

Comment on attachment 179734 [details]
Patch

Rejecting attachment 179734 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
mnt/git/webkit-commit-queue

Parsed 2 diffs from patch file(s).
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/Scripts/webkitpy/common/config/committers.py
Hunk #1 FAILED at 116.
Hunk #2 succeeded at 166 (offset 2 lines).
1 out of 2 hunks FAILED -- saving rejects to file Tools/Scripts/webkitpy/common/config/committers.py.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/15371718

[Peter Beverloo]

Committed r137904: <http://trac.webkit.org/changeset/137904>