Bug 105013 - [chromium] move editing callback dumping to the WebTestProxy
Summary: [chromium] move editing callback dumping to the WebTestProxy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-14 04:58 PST by jochen
Modified: 2012-12-18 00:27 PST (History)
6 users (show)

See Also:

Attachments
Patch (40.96 KB, patch)
2012-12-14 05:06 PST, jochen 		no flags Details | Formatted Diff | Diff
Patch (40.97 KB, patch)
2012-12-14 13:15 PST, jochen 		no flags Details | Formatted Diff | Diff
Patch for landing (40.90 KB, patch)
2012-12-17 23:59 PST, jochen 		no flags Details | Formatted Diff | Diff
Patch for landing (40.91 KB, patch)
2012-12-18 00:07 PST, jochen 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2012-12-14 04:58:13 PST 
[chromium] move editing callback dumping to the WebTestProxy
Comment 1 jochen 2012-12-14 05:06:29 PST 
Created attachment 179468 [details]
Patch
Comment 2 WebKit Review Bot 2012-12-14 05:08:38 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Tony Chang 2012-12-14 10:57:51 PST 
Comment on attachment 179468 [details]
Patch

LGTM
Comment 4 Tony Chang 2012-12-14 10:58:26 PST 
Comment on attachment 179468 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179468&action=review

> Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h:60
> +    // WebTestRunner implementation.
> +    virtual bool shouldDumpEditingCallbacks() const;

Nit: OVERRIDE.
Comment 5 jochen 2012-12-14 13:15:38 PST 
Created attachment 179522 [details]
Patch
Comment 6 jochen 2012-12-14 13:15:59 PST 
(In reply to comment #4)
> (From update of attachment 179468 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=179468&action=review
> 
> > Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h:60
> > +    // WebTestRunner implementation.
> > +    virtual bool shouldDumpEditingCallbacks() const;
> 
> Nit: OVERRIDE.

done
Comment 7 jochen 2012-12-14 13:16:14 PST 
Darin, can you have a look please?
Comment 8 Darin Fisher (:fishd, Google) 2012-12-17 22:19:54 PST 
Comment on attachment 179522 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179522&action=review

> Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:47
>  struct WebPoint;

nit: list classes and then structs.  "class" sorts alphabetically before "struct"
Comment 9 jochen 2012-12-17 23:59:42 PST 
Created attachment 179888 [details]
Patch for landing
Comment 10 jochen 2012-12-18 00:07:50 PST 
Created attachment 179893 [details]
Patch for landing
Comment 11 WebKit Review Bot 2012-12-18 00:27:04 PST 
Comment on attachment 179893 [details]
Patch for landing

Clearing flags on attachment: 179893

Committed r137993: <http://trac.webkit.org/changeset/137993>
Comment 12 WebKit Review Bot 2012-12-18 00:27:08 PST 
All reviewed patches have been landed.  Closing bug.