Bug 105013 – [chromium] move editing callback dumping to the WebTestProxy

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[chromium] move editing callback dumping to the WebTestProxy

Created attachment 179468 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Tony Chang]

Comment on attachment 179468 [details]
Patch

LGTM

[Tony Chang]

Comment on attachment 179468 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179468&action=review

> Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h:60
> +    // WebTestRunner implementation.
> +    virtual bool shouldDumpEditingCallbacks() const;

Nit: OVERRIDE.

Created attachment 179522 [details]
Patch

(In reply to comment #4)
> (From update of attachment 179468 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=179468&action=review
> 
> > Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h:60
> > +    // WebTestRunner implementation.
> > +    virtual bool shouldDumpEditingCallbacks() const;
> 
> Nit: OVERRIDE.

done

Darin, can you have a look please?

[Darin Fisher (:fishd, Google)]

Comment on attachment 179522 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179522&action=review

> Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:47
>  struct WebPoint;

nit: list classes and then structs.  "class" sorts alphabetically before "struct"

Created attachment 179888 [details]
Patch for landing

Created attachment 179893 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 179893 [details]
Patch for landing

Clearing flags on attachment: 179893

Committed r137993: <http://trac.webkit.org/changeset/137993>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.