Bug 105008 - [WK2] Enable tests that use boolean overridePreference
Summary: [WK2] Enable tests that use boolean overridePreference
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jussi Kukkonen (jku)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-14 03:12 PST by Jussi Kukkonen (jku)
Modified: 2012-12-17 06:05 PST (History)
5 users (show)

See Also:


Attachments
Results from efl, lets see how mac and chromium EWS take this... (8.18 KB, patch)
2012-12-14 06:24 PST, Jussi Kukkonen (jku)
no flags Details | Formatted Diff | Diff
Patch (15.53 KB, patch)
2012-12-16 11:12 PST, Jussi Kukkonen (jku)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jussi Kukkonen (jku) 2012-12-14 03:12:22 PST
I was looking at bug 95578 and realised we have loads of tests skipped with this comment:
 # WebKit2 needs layoutTestController.overridePreference
 # <https://bugs.webkit.org/show_bug.cgi?id=42197>
My understanding is that overriding boolean preferences already works and it looks like these tests mostly use a boolean override... I run the tests and 82/99 tests pass on wk2-efl.
Comment 1 Jussi Kukkonen (jku) 2012-12-14 06:24:23 PST
Created attachment 179473 [details]
Results from efl, lets see how mac and chromium EWS take this...
Comment 2 Jussi Kukkonen (jku) 2012-12-16 11:12:59 PST
Created attachment 179652 [details]
Patch
Comment 3 WebKit Review Bot 2012-12-17 06:05:24 PST
Comment on attachment 179652 [details]
Patch

Clearing flags on attachment: 179652

Committed r137902: <http://trac.webkit.org/changeset/137902>
Comment 4 WebKit Review Bot 2012-12-17 06:05:29 PST
All reviewed patches have been landed.  Closing bug.