WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
105008
[WK2] Enable tests that use boolean overridePreference
https://bugs.webkit.org/show_bug.cgi?id=105008
Summary
[WK2] Enable tests that use boolean overridePreference
Jussi Kukkonen (jku)
Reported
2012-12-14 03:12:22 PST
I was looking at
bug 95578
and realised we have loads of tests skipped with this comment: # WebKit2 needs layoutTestController.overridePreference # <
https://bugs.webkit.org/show_bug.cgi?id=42197
> My understanding is that overriding boolean preferences already works and it looks like these tests mostly use a boolean override... I run the tests and 82/99 tests pass on wk2-efl.
Attachments
Results from efl, lets see how mac and chromium EWS take this...
(8.18 KB, patch)
2012-12-14 06:24 PST
,
Jussi Kukkonen (jku)
no flags
Details
Formatted Diff
Diff
Patch
(15.53 KB, patch)
2012-12-16 11:12 PST
,
Jussi Kukkonen (jku)
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Jussi Kukkonen (jku)
Comment 1
2012-12-14 06:24:23 PST
Created
attachment 179473
[details]
Results from efl, lets see how mac and chromium EWS take this...
Jussi Kukkonen (jku)
Comment 2
2012-12-16 11:12:59 PST
Created
attachment 179652
[details]
Patch
WebKit Review Bot
Comment 3
2012-12-17 06:05:24 PST
Comment on
attachment 179652
[details]
Patch Clearing flags on attachment: 179652 Committed
r137902
: <
http://trac.webkit.org/changeset/137902
>
WebKit Review Bot
Comment 4
2012-12-17 06:05:29 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug