Bug 105000 – Allow built-in PDF plugin and plugin documents to auto-start

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Jon Lee]

Give the loader client an opportunity to prevent a plug-in being snapshot.

<rdar://problem/12633351>

[Jon Lee]

Created attachment 179447 [details]
Patch

[Early Warning System Bot]

Comment on attachment 179447 [details]
Patch

Attachment 179447 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15311608

[Jon Lee]

Created attachment 179449 [details]
Patch

[Early Warning System Bot]

Comment on attachment 179449 [details]
Patch

Attachment 179449 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15310645

[Jon Lee]

Created attachment 179452 [details]
Patch

[Tim Horton]

Comment on attachment 179452 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179452&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:161
> +    WKBundlePageShouldSnapshotPlugInMIMETypeCallback                        shouldSnapshotPlugInMIMEType;

Can you just throw this on the end of the API like this? How does versioning work?

[Jon Lee]

Tacking that function at the end is ok in this case, because the current version goes beyond what has shipped in previous Safari. When a product ships at a certain version, it's a hard stop, and we have to increment the number.

[Jon Lee]

Redefine the rules to:

1) PlugInDocs run automatically
2) Build-in PDF runs automatically
3) else snapshot

[Jon Lee]

Created attachment 179642 [details]
Patch

[Jon Lee]

Committed r137868: <http://trac.webkit.org/changeset/137868>