Continued from https://bugs.webkit.org/show_bug.cgi?id=104628 and https://bugs.webkit.org/show_bug.cgi?id=104985. Make hours fields of multiple-fields UI respect step attribute.
Created attachment 179427 [details] Patch
Comment on attachment 179427 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179427&action=review > LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html:160 > +shouldBeEqualToString('test("06:00", 7200, null, null, ["delete", "downArrow"])', '00:00'); In this case, do we have appearance "12:00 am" correctly instead of "00:00 am"? We can test it by getUserAgentShadowTextContent() defined in fast/forms/resources/common.js.
Comment on attachment 179427 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179427&action=review > LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt:111 > +The tests in this block fail on platforms without the lang-attribute-aware-form-control-UI feature. We know this block will fail on Windows XP. So, please add the following line to LayoutTests/platform/chromium/TestExpectations webkit.org/b/104993 [ XP ] fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html [ Failure ]
Created attachment 179443 [details] Patch 2
Comment on attachment 179427 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179427&action=review >> LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt:111 >> +The tests in this block fail on platforms without the lang-attribute-aware-form-control-UI feature. > > We know this block will fail on Windows XP. > So, please add the following line to LayoutTests/platform/chromium/TestExpectations > > webkit.org/b/104993 [ XP ] fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html [ Failure ] Done. >> LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html:160 >> +shouldBeEqualToString('test("06:00", 7200, null, null, ["delete", "downArrow"])', '00:00'); > > In this case, do we have appearance "12:00 am" correctly instead of "00:00 am"? > We can test it by getUserAgentShadowTextContent() defined in fast/forms/resources/common.js. Added test of shadow text here and 0-23 case.
Comment on attachment 179443 [details] Patch 2 Looks good.
Comment on attachment 179443 [details] Patch 2 Clearing flags on attachment: 179443 Committed r137733: <http://trac.webkit.org/changeset/137733>
All reviewed patches have been landed. Closing bug.