Bug 104991 - Copy platform/win/fast/events/panScroll-* to platform/chromium-win/fast/events
Summary: Copy platform/win/fast/events/panScroll-* to platform/chromium-win/fast/events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on:
Blocks: 104764 104998
  Show dependency treegraph
 
Reported: 2012-12-13 21:12 PST by yosin
Modified: 2012-12-14 00:32 PST (History)
3 users (show)

See Also:


Attachments
Patch 1 (11.86 KB, patch)
2012-12-13 21:51 PST, yosin
no flags Details | Formatted Diff | Diff
Patch 2 (13.07 KB, patch)
2012-12-13 22:52 PST, yosin
morrita: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-12-13 21:12:44 PST
Chromium-Win port also wants to use pan scroll tests.
Comment 1 yosin 2012-12-13 21:51:00 PST
Created attachment 179415 [details]
Patch 1
Comment 2 yosin 2012-12-13 21:53:37 PST
Comment on attachment 179415 [details]
Patch 1

Could you review this patch?
Thanks in advance.

All files, except for ChangeLog, are copied w/o modification.
Comment 3 WebKit Review Bot 2012-12-13 22:38:17 PST
Comment on attachment 179415 [details]
Patch 1

Attachment 179415 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15312557

New failing tests:
platform/chromium-win/fast/events/panScroll-nested-divs.html
platform/chromium-win/fast/events/panScroll-event-fired.html
platform/chromium-win/fast/events/panScroll-click-hyperlink.html
Comment 4 yosin 2012-12-13 22:52:30 PST
Created attachment 179420 [details]
Patch 2
Comment 5 yosin 2012-12-13 23:47:36 PST
Comment on attachment 179420 [details]
Patch 2

Could you review this patch?
Thanks in advance.

P.S.
It seems cr-android bot has trouble fetching GIT files.
Comment 6 Hajime Morrita 2012-12-14 00:07:17 PST
Comment on attachment 179420 [details]
Patch 2

r=me. Please add comments that mentions this does copy in separate change.
Comment 7 yosin 2012-12-14 00:15:54 PST
Reverted r137719 for reason:

Wrong commit

Committed r137722: <http://trac.webkit.org/changeset/137722>
Comment 8 yosin 2012-12-14 00:20:46 PST
Reverted r137720 for reason:

Wrong Commit

Committed r137723: <http://trac.webkit.org/changeset/137723>
Comment 9 yosin 2012-12-14 00:29:44 PST
Committed:
http://trac.webkit.org/changeset/137725