CLOSED FIXED 10498
[S60] Valid phone number cannot be identified by smart text on a page that is generated by javascript. 
https://bugs.webkit.org/show_bug.cgi?id=10498
Summary [S60] Valid phone number cannot be identified by smart text on a page that is...
Joseph Ligman
Reported 2006-08-21 11:21:06 PDT
TSW Bug ID: YZHG-6SPSPB How to reproduce: - Precondition: Browser's auto find item is set to "On". - load page (see TSW) - click link "Search in script" - move the pointer over the first valid number "12346585" Expected result: The image of the pointer should be changed to a phone like image Actual result: The image of the pointer stays unchanged
Attachments
Files: WebCoreBridge.h/cpp, SmartLinkMap.cpp (10.26 KB, patch)
2006-08-21 15:44 PDT, Joseph Ligman 		zalan: review-
DetailsFormatted DiffDiff
Files: WebCoreBridge.h/cpp, SmartLinkMap.cpp (10.29 KB, patch)
2006-09-06 10:42 PDT, Joseph Ligman 		zalan: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Ligman
Comment 1 2006-08-21 15:44:38 PDT
Created attachment 10158 [details] Files: WebCoreBridge.h/cpp, SmartLinkMap.cpp The text buffer returned from CWebCoreBridge::GetNextRenderTextForSmartLinks was getting prematurely deleted. To resolve store a copy in the WebCore and remove the copy from Webkit since it is no longer needed.
zalan
Comment 2 2006-08-24 13:16:04 PDT
Comment on attachment 10158 [details] Files: WebCoreBridge.h/cpp, SmartLinkMap.cpp webcorebridge.cpp line1468: if allocL fails, then iSmartTextBuffer will point to garbage and it will crash in the ~webcorebridge destructor.
Joseph Ligman
Comment 3 2006-09-06 10:42:06 PDT
Created attachment 10418 [details] Files: WebCoreBridge.h/cpp, SmartLinkMap.cpp Set iSmartTextBuffer = NULL after deletion to avoid the potential crash if the memory allocation fails.
zalan
Comment 4 2006-09-08 05:35:06 PDT
Comment on attachment 10418 [details] Files: WebCoreBridge.h/cpp, SmartLinkMap.cpp r=me
zalan
Comment 5 2006-09-08 05:44:39 PDT
r16269
Krishna
Comment 6 2006-09-27 10:04:39 PDT
Verified and Closed.
Joel Parks
Comment 7 2011-03-21 11:52:31 PDT
re-purposing InTSW keyword for use by QtWebkit team
Note You need to log in before you can comment on or make changes to this bug.