Bug 104978 – Fix build warning

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sanghyup Lee]

Bug 104936 incorrectly remove code that initialize downloadID. Need to initialize downloadID to fix build warning.

Source/WebKit2/WebProcess/Downloads/Download.cpp:47:1: warning: unused parameter ‘downloadID’ [-Wunused-parameter]

[Sanghyup Lee]

Created attachment 179387 [details]
Patch

[Kentaro Hara]

Comment on attachment 179387 [details]
Patch

ok

[Early Warning System Bot]

Comment on attachment 179387 [details]
Patch

Attachment 179387 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15310532

[Ryuan Choi]

Comment on attachment 179387 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179387&action=review

> Source/WebKit2/WebProcess/Downloads/Download.cpp:49
> +    : m_downloadID(downloadID)
>      : m_downloadManager(downloadManager)

Oops, this is wrong.

: should be ,

[Sanghyup Lee]

Created attachment 179391 [details]
Patch

[Kentaro Hara]

Comment on attachment 179391 [details]
Patch

sorry for overlooking the ,

[Early Warning System Bot]

Comment on attachment 179391 [details]
Patch

Attachment 179391 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15319487

[Kentaro Hara]

Maybe removing the initializer might be intentional. Let's wait for a comment from the patch author (See https://bugs.webkit.org/show_bug.cgi?id=104936).

[KyungTae Kim]

The build error is because of the order of the initialization list.
Please put the initialization of m_downloadID below the initialization of  m_downloadManager same with the header.

Source/WebKit2/WebProcess/Downloads/Download.cpp: In constructor ‘WebKit::Download::Download(WebKit::DownloadManager&, uint64_t, const WebCore::ResourceRequest&)’:
Source/WebKit2/WebProcess/Downloads/Download.cpp:49:5: error: expected identifier before ‘,’ token
Source/WebKit2/WebProcess/Downloads/Download.h:128:14: error: ‘WebKit::Download::m_downloadID’ will be initialized after [-Werror=reorder]
Source/WebKit2/WebProcess/Downloads/Download.h:127:22: error:   ‘WebKit::DownloadManager& WebKit::Download::m_downloadManager’ [-Werror=reorder]
Source/WebKit2/WebProcess/Downloads/Download.cpp:47:1: error:   when initialized here [-Werror=reorder]

[WebKit Review Bot]

Comment on attachment 179391 [details]
Patch

Attachment 179391 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15321467

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html

[Sanghyup Lee]

Created attachment 179403 [details]
Patch

[Kentaro Hara]

Comment on attachment 179403 [details]
Patch

Let's wait for a comment from the author of the original patch before landing.

[Darin Adler]

We don’t need to wait to land this. It seems clear this was just an editing error. Please land ASAP.

[WebKit Review Bot]

Comment on attachment 179403 [details]
Patch

Rejecting attachment 179403 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
commit-queue/Source/WebKit/chromium/third_party/v8-i18n --revision 159 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
53>At revision 159.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/15321537

[Kentaro Hara]

Comment on attachment 179403 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179403&action=review

> Source/WebKit2/ChangeLog:8
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

You need to describe a change description here. (OOPS is not allowed)

[Sanghyup Lee]

Created attachment 179421 [details]
Patch

[WebKit Review Bot]

Comment on attachment 179421 [details]
Patch

Clearing flags on attachment: 179421

Committed r137716: <http://trac.webkit.org/changeset/137716>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Anders Carlsson]

Thanks for fixing this!