Bug 104957 - Make --profile output easier to understand for pprof on linux
Summary: Make --profile output easier to understand for pprof on linux
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-13 14:41 PST by Eric Seidel (no email)
Modified: 2012-12-13 15:31 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.74 KB, patch)
2012-12-13 14:43 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2012-12-13 14:41:55 PST
Make --profile output easier to understand for pprof on linux
Comment 1 Eric Seidel (no email) 2012-12-13 14:43:08 PST
Created attachment 179343 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-12-13 14:44:02 PST
Now the output looks like this:

%run-perf-tests --profile --chromium Bindings
Running 24 tests
Running Bindings/append-child.html (1 of 24)
Finished: 16.911530 s

First 10 lines of pprof --text:
     150   9.0%   9.0%      150   9.0% __pthread_getspecific
     138   8.2%  17.2%      152   9.1% v8::internal::Object::IsFunctionTemplateInfo (inline)
     120   7.2%  24.4%      231  13.8% lookup (inline)
     111   6.6%  31.0%      111   6.6% intHash (inline)
      81   4.8%  35.8%      104   6.2% v8::Object::GetAlignedPointerFromInternalField (inline)
      55   3.3%  39.1%      138   8.2% WebCore::ContainerNode::appendChild
      53   3.2%  42.3%      317  18.9% WTF::HashTable::find
      45   2.7%  45.0%       45   2.7% WebCore::TreeShared::deref (inline)
      44   2.6%  47.6%     1382  82.6% WebCore::V8Node::appendChildCallback
      43   2.6%  50.2%      354  21.1% v8::FunctionTemplate::HasInstance

http://google-perftools.googlecode.com/svn/trunk/doc/cpuprofile.html documents output.

To interact with the the full profile, including produce graphs:
/usr/bin/google-pprof /src/WebKit/out/Release/DumpRenderTree /src/WebKit/Source/WebKit/chromium/webkit/Release/layout-test-results/test-15.pprof
Comment 3 WebKit Review Bot 2012-12-13 15:31:52 PST
Comment on attachment 179343 [details]
Patch

Clearing flags on attachment: 179343

Committed r137666: <http://trac.webkit.org/changeset/137666>
Comment 4 WebKit Review Bot 2012-12-13 15:31:56 PST
All reviewed patches have been landed.  Closing bug.