Move MutationObserver tests to fast/dom/MutationObserver
Created attachment 179327 [details] Patch
Comment on attachment 179327 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179327&action=review rs=me as long as you’re using svn mv. > LayoutTests/ChangeLog:10 > + * fast/dom/MutationObserver/added-out-of-order-expected.txt: Renamed from LayoutTests/fast/mutation/added-out-of-order-expected.txt. I don’t think we need to list every single test we’re moving. Just add: * fast/dom/MutationObserver/: Renamed from fast/mutation/.
There's no other CamelCase directories in LayoutTests/fast, can we name this "mutation-observer" or "mutationobserver" ?
(In reply to comment #3) > There's no other CamelCase directories in LayoutTests/fast, can we name this "mutation-observer" or "mutationobserver" ? There are _lots_ of them under fast/dom/: Node NodeList Orientation Range Selection SelectorAPI StyleSheet Text TreeWalker etc, most of them named after their IDL name
(In reply to comment #3) > There's no other CamelCase directories in LayoutTests/fast, can we name this "mutation-observer" or "mutationobserver" ? Our preferred naming scheme is CamelCase. For starters, fast should be Fast.
(In reply to comment #4) > (In reply to comment #3) > > There's no other CamelCase directories in LayoutTests/fast, can we name this "mutation-observer" or "mutationobserver" ? > > There are _lots_ of them under fast/dom/: > > Node > NodeList > Orientation > Range > Selection > SelectorAPI > StyleSheet > Text > TreeWalker > > etc, most of them named after their IDL name Oh I see, it's fast/dom/MutationObserver, I missed the "dom" in the middle. Sounds good.
Created attachment 179330 [details] Patch
(In reply to comment #2) > (From update of attachment 179327 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=179327&action=review > > rs=me as long as you’re using svn mv. Does the CQ not know how to move files? I've uploaded a patch for landing, but will apply it to an SVN checkout if I need to.
(In reply to comment #8) > (In reply to comment #2) > > (From update of attachment 179327 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=179327&action=review > > > > rs=me as long as you’re using svn mv. > > Does the CQ not know how to move files? I've uploaded a patch for landing, but will apply it to an SVN checkout if I need to. It might but I won’t count on it.
(In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #2) > > > (From update of attachment 179327 [details] [details] [details]) > > > View in context: https://bugs.webkit.org/attachment.cgi?id=179327&action=review > > > > > > rs=me as long as you’re using svn mv. > > > > Does the CQ not know how to move files? I've uploaded a patch for landing, but will apply it to an SVN checkout if I need to. > > It might but I won’t count on it. I'll try it and roll out if the results aren't to your liking, I don't have an SVN checkout here.
Comment on attachment 179330 [details] Patch Let me do that for you then.
Comment on attachment 179330 [details] Patch Per IRC discussion, it might work after all. Let’s give a shot.
Comment on attachment 179330 [details] Patch Clearing flags on attachment: 179330 Committed r137662: <http://trac.webkit.org/changeset/137662>
All reviewed patches have been landed. Closing bug.