Bug 104943 – Out-of-view check of fixed position element in frame is incorrect when page is scaled

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Xianzhu Wang]

Fixed position element in a frame disappears when the page is scaled and the frame is scrolled to a certain position.

This bug is caused by my patch to bug 104303. The layerBounds should be scaled by the frameScaleFactor, not pageScaleFactor. I should have include tests for fixed position in frames in bug 104303.

Will upload a patch soon.

[Xianzhu Wang]

Created attachment 179328 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 179328 [details]
Patch

I'm not sure what the layer dumps tell me in the -expected files.

[Xianzhu Wang]

Created attachment 179335 [details]
Add comments in tests

[Xianzhu Wang]

(In reply to comment #2)
> (From update of attachment 179328 [details])
> I'm not sure what the layer dumps tell me in the -expected files.

They expect that the layer tree in the frame is not affected by page scale. Added comments in the new patch.

[Eric Seidel (no email)]

Why not just capture the layer tree in a string, change the scale and assert they were identical?

that would allow you to just print "PASS" or "FAIL" (presumably with the dump off the full tree in the fail case) and have much easier to understand/maintain tests. :)

[Xianzhu Wang]

(In reply to comment #5)
> Why not just capture the layer tree in a string, change the scale and assert they were identical?
> 
> that would allow you to just print "PASS" or "FAIL" (presumably with the dump off the full tree in the fail case) and have much easier to understand/maintain tests. :)

I thought that dumping layer tree of the frame from the main page wouldn't work, so I dumped the layer tree of the whole page causing difficulty to compare the result. Just tried and it works because window.internals API doesn't check domains.

[Xianzhu Wang]

Created attachment 179356 [details]
PASS/FAIL

[WebKit Review Bot]

Comment on attachment 179356 [details]
PASS/FAIL

Attachment 179356 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15312474

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html

[Xianzhu Wang]

Comment on attachment 179356 [details]
PASS/FAIL

The failure seems unrelated. Try cq+ again.

[WebKit Review Bot]

Comment on attachment 179356 [details]
PASS/FAIL

Rejecting attachment 179356 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Kit/chromium/third_party/yasm/source/patched-yasm --revision 167605 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
53>At revision 167605.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/15314506

[Xianzhu Wang]

Created attachment 179394 [details]
Rebased, for landing

[WebKit Review Bot]

Comment on attachment 179394 [details]
Rebased, for landing

Clearing flags on attachment: 179394

Committed r137697: <http://trac.webkit.org/changeset/137697>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Beth Dakin]

These tests are failing on Mac.

[Simon Fraser (smfr)]

In WebKit1, layer trees for pages with iframes can differ from WK2. The root document may not have any layers.