Bug 104932 – PrettyDiff.rb fails to render image diffs with Ruby 1.9.3p194

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Martin Robinson]

When rendering image diffs with Ruby 1.9.3p194, instead of the image diffs in the output, I see this:

Exception raised during decoding git binary patch:

invalid byte sequence in UTF-8
/home/martin/WebKit/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:680:in `match'
/home/martin/WebKit/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:680:in `match'
/home/martin/WebKit/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:680:in `read_checksum_from_png'
/home/martin/WebKit/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:589:in `block in initialize'
/home/martin/WebKit/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:589:in `collect'
/home/martin/WebKit/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:589:in `initialize'
/home/martin/WebKit/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:675:in `new'
/home/martin/WebKit/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:675:in `block in parse'
/home/martin/WebKit/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:675:in `collect'
/home/martin/WebKit/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:675:in `parse'
/home/martin/WebKit/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:33:in `prettify'
/home/martin/WebKit/Websites/bugs.webkit.org/PrettyPatch/prettify.rb:26:in `<main>'

[Martin Robinson]

Created attachment 179433 [details]
Patch

[Martin Robinson]

See also: https://bugs.webkit.org/show_bug.cgi?id=91212

[Eric Seidel (no email)]

Comment on attachment 179433 [details]
Patch

Seems reasonable.

[WebKit Review Bot]

Comment on attachment 179433 [details]
Patch

Rejecting attachment 179433 [details] from commit-queue.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
eidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Parsed 2 diffs from patch file(s).
patching file Websites/bugs.webkit.org/ChangeLog
patching file Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb
Hunk #1 FAILED at 676.
1 out of 1 hunk FAILED -- saving rejects to file Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/15591198

[Martin Robinson]

Committed r138585: <http://trac.webkit.org/changeset/138585>