Bug 104931 – [GTK] Safeguard against possible NULL-dereference

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Claudio Saavedra]

[GTK] Safeguard against possible NULL-dereference

[Claudio Saavedra]

Created attachment 179298 [details]
Patch

[WebKit Review Bot]

Comment on attachment 179298 [details]
Patch

Clearing flags on attachment: 179298

Committed r137633: <http://trac.webkit.org/changeset/137633>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Claudio Saavedra]

The patch is actually broken as it doesn't let the other cases be handled. I'll attach a sane version now, sorry for this.

[Claudio Saavedra]

Created attachment 182959 [details]
Patch

[Martin Robinson]

Comment on attachment 182959 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182959&action=review

> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:412
> -    if (!parent)
> -        return -1;
> -
>      if (!parent && isRootObject(coreObject)) {
>          AtkObject* atkParent = atkParentOfRootObject(object);
>          if (!atkParent)

Looks good to me, but I'd like Joanie or Mario to do an unofficial review here.

[Joanmarie Diggs]

(In reply to comment #6)

> Looks good to me, but I'd like Joanie or Mario to do an unofficial review here.

Looks good to me as well. Thanks for doing it Claudio!!

[WebKit Review Bot]

Comment on attachment 182959 [details]
Patch

Clearing flags on attachment: 182959

Committed r139890: <http://trac.webkit.org/changeset/139890>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.