Bug 104931 - [GTK] Safeguard against possible NULL-dereference
Summary: [GTK] Safeguard against possible NULL-dereference
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 104114
  Show dependency tree / graph
 
Reported: 2012-12-13 10:18 PST by Claudio Saavedra
Modified: 2013-01-16 10:01 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.53 KB, patch)
2012-12-13 10:19 PST, Claudio Saavedra 		no flags Details | Formatted Diff | Diff
Patch (1.84 KB, patch)
2013-01-16 04:24 PST, Claudio Saavedra 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Claudio Saavedra 2012-12-13 10:18:18 PST 
[GTK] Safeguard against possible NULL-dereference
Comment 1 Claudio Saavedra 2012-12-13 10:19:56 PST 
Created attachment 179298 [details]
Patch
Comment 2 WebKit Review Bot 2012-12-13 11:52:52 PST 
Comment on attachment 179298 [details]
Patch

Clearing flags on attachment: 179298

Committed r137633: <http://trac.webkit.org/changeset/137633>
Comment 3 WebKit Review Bot 2012-12-13 11:52:55 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Claudio Saavedra 2013-01-16 04:14:05 PST 
The patch is actually broken as it doesn't let the other cases be handled. I'll attach a sane version now, sorry for this.
Comment 5 Claudio Saavedra 2013-01-16 04:24:28 PST 
Created attachment 182959 [details]
Patch
Comment 6 Martin Robinson 2013-01-16 06:17:15 PST 
Comment on attachment 182959 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182959&action=review

> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:412
> -    if (!parent)
> -        return -1;
> -
>      if (!parent && isRootObject(coreObject)) {
>          AtkObject* atkParent = atkParentOfRootObject(object);
>          if (!atkParent)

Looks good to me, but I'd like Joanie or Mario to do an unofficial review here.
Comment 7 Joanmarie Diggs 2013-01-16 06:24:49 PST 
(In reply to comment #6)

> Looks good to me, but I'd like Joanie or Mario to do an unofficial review here.

Looks good to me as well. Thanks for doing it Claudio!!
Comment 8 WebKit Review Bot 2013-01-16 10:01:42 PST 
Comment on attachment 182959 [details]
Patch

Clearing flags on attachment: 182959

Committed r139890: <http://trac.webkit.org/changeset/139890>
Comment 9 WebKit Review Bot 2013-01-16 10:01:46 PST 
All reviewed patches have been landed.  Closing bug.