Bug 104931 - [GTK] Safeguard against possible NULL-dereference
: [GTK] Safeguard against possible NULL-dereference
Status: RESOLVED FIXED
: WebKit
WebKit Gtk
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
: 104114
  Show dependency treegraph
 
Reported: 2012-12-13 10:18 PST by
Modified: 2013-01-16 10:01 PST (History)


Attachments
Patch (1.53 KB, patch)
2012-12-13 10:19 PST, Claudio Saavedra
no flags Review Patch | Details | Formatted Diff | Diff
Patch (1.84 KB, patch)
2013-01-16 04:24 PST, Claudio Saavedra
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-12-13 10:18:18 PST
[GTK] Safeguard against possible NULL-dereference
------- Comment #1 From 2012-12-13 10:19:56 PST -------
Created an attachment (id=179298) [details]
Patch
------- Comment #2 From 2012-12-13 11:52:52 PST -------
(From update of attachment 179298 [details])
Clearing flags on attachment: 179298

Committed r137633: <http://trac.webkit.org/changeset/137633>
------- Comment #3 From 2012-12-13 11:52:55 PST -------
All reviewed patches have been landed.  Closing bug.
------- Comment #4 From 2013-01-16 04:14:05 PST -------
The patch is actually broken as it doesn't let the other cases be handled. I'll attach a sane version now, sorry for this.
------- Comment #5 From 2013-01-16 04:24:28 PST -------
Created an attachment (id=182959) [details]
Patch
------- Comment #6 From 2013-01-16 06:17:15 PST -------
(From update of attachment 182959 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=182959&action=review

> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:412
> -    if (!parent)
> -        return -1;
> -
>      if (!parent && isRootObject(coreObject)) {
>          AtkObject* atkParent = atkParentOfRootObject(object);
>          if (!atkParent)

Looks good to me, but I'd like Joanie or Mario to do an unofficial review here.
------- Comment #7 From 2013-01-16 06:24:49 PST -------
(In reply to comment #6)

> Looks good to me, but I'd like Joanie or Mario to do an unofficial review here.

Looks good to me as well. Thanks for doing it Claudio!!
------- Comment #8 From 2013-01-16 10:01:42 PST -------
(From update of attachment 182959 [details])
Clearing flags on attachment: 182959

Committed r139890: <http://trac.webkit.org/changeset/139890>
------- Comment #9 From 2013-01-16 10:01:46 PST -------
All reviewed patches have been landed.  Closing bug.