Bug 104926 – [EFL] Add more accessibility test and expected results

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebKit EFL

[Mateusz Leszko]

Created attachment 179288 [details]
Added some accessiblity tests

Added some accessiblity tests from:
platform/gtk/accessibility
platform/mac/accessibility
platform/chromium/accessibility

Due to turning on accessiblity in EFL.

[WebKit Review Bot]

Attachment 179288 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 40 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Mateusz Leszko]

Created attachment 179290 [details]
Added some accessiblity tests

added bug number

[Alejandro Piñeiro]

I noticed your patch and had a couple of questions:

* Given that the EFL and GTK port now share a single accessibility implementation, does it make sense to duplicate tests from the GTK port? Wouldn't it make more sense to share the accessibility tests? (i.e. renaming gtk platform to atk platform).

* In the same way, with this patch you are copying some mac-chromium specific platform tests to EFL. If you got those tests working, it would suggest that those tests work for all of our platforms and should be moved to the shared test set.

Am I missing something that makes your proposed solution the preferred one? In general, our goal is to get as many shared tests as possible and this seems to be moving in the opposite direction.

[Mateusz Leszko]

You might be interested in sharing tests bug https://bugs.webkit.org/show_bug.cgi?id=104662

[Gyuyoung Kim]

(In reply to comment #4)
> You might be interested in sharing tests bug https://bugs.webkit.org/show_bug.cgi?id=104662

Please link this bug to Bug 104662

[Gyuyoung Kim]

Comment on attachment 179290 [details]
Added some accessiblity tests

View in context: https://bugs.webkit.org/attachment.cgi?id=179290&action=review

> LayoutTests/ChangeLog:12
> +        due to turning on accessiblity in EFL.

I think we have to move common test case files to common place(e.g. LayoutTests/accessibility). Are you thinking about it ?

[Mateusz Leszko]

(In reply to comment #6)
> 
> I think we have to move common test case files to common place(e.g. LayoutTests/accessibility). Are you thinking about it ?

Yes, I will try to add those tests to LayoutTests/accessibility/atk. I'll put a patch soon.

[Mateusz Leszko]

There is a discussion and problem what solution choose. This one or the one from https://bugs.webkit.org/show_bug.cgi?id=104662

[Anders Carlsson]

Comment on attachment 179290 [details]
Added some accessiblity tests

Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.

[Michael Catanzaro]

Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.