Bug 104925 - Text Autosizing: Don't autosize unwrappable blocks
Summary: Text Autosizing: Don't autosize unwrappable blocks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Mellor
URL:
Keywords:
Depends on:
Blocks: FontBoosting
  Show dependency tree / graph
 
Reported: 2012-12-13 09:25 PST by John Mellor
Modified: 2012-12-14 03:59 PST (History)
6 users (show)

See Also:

Attachments
Patch (15.66 KB, patch)
2012-12-13 09:31 PST, John Mellor 		no flags Details | Formatted Diff | Diff
Patch (15.67 KB, patch)
2012-12-14 03:40 PST, John Mellor 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Mellor 2012-12-13 09:25:24 PST 
Text Autosizing: Don't autosize unwrappable blocks
Comment 1 John Mellor 2012-12-13 09:31:57 PST 
Created attachment 179287 [details]
Patch
Comment 2 John Mellor 2012-12-13 09:32:58 PST 
Kenneth/Julien, does this look good?
Comment 3 John Mellor 2012-12-13 10:17:37 PST 
By the way, I tested this on 2000 popular homepages and the results were overwhelmingly positive. In particular it fixes a nasty issue on newegg.com where the font size of a div toggle between autosized and non-autosized everytime there is a layout (i.e. several times while the page incrementally renders, and every time you hover over a menu item) - http://crbug.com/165922
Comment 4 Julien Chaffraix 2012-12-13 15:11:43 PST 
Comment on attachment 179287 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179287&action=review

> Source/WebCore/ChangeLog:19
> +            Use containerShouldbeAutosized instead of contentHeightIsConstrained|

Not sure why you put a '|' at the end of your sentence, but AFAICT English uses a '.' :)

> Source/WebCore/ChangeLog:25
> +            Use containerShouldbeAutosized instead of contentHeightIsConstrained|

Ditto.

> Source/WebCore/ChangeLog:27
> +            Declared containerShouldbeAutosized

Missing final dot.
Comment 5 Kenneth Rohde Christiansen 2012-12-13 23:36:10 PST 
Looks fine to me, except the | thing Julien pointed out.
Comment 6 John Mellor 2012-12-14 03:40:40 PST 
Created attachment 179465 [details]
Patch
Comment 7 John Mellor 2012-12-14 03:41:26 PST 
Comment on attachment 179465 [details]
Patch

Carrying forward reviews above.
Comment 8 WebKit Review Bot 2012-12-14 03:59:41 PST 
Comment on attachment 179465 [details]
Patch

Clearing flags on attachment: 179465

Committed r137738: <http://trac.webkit.org/changeset/137738>
Comment 9 WebKit Review Bot 2012-12-14 03:59:45 PST 
All reviewed patches have been landed.  Closing bug.