Bug 104911 – [chromium] Add a virtual test suite for enabling opt-in to composited scrolling

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

We need to add virtual suites to run the tests in compositing/overflow/ and scrollbars/ with the --enable-accelerated-compositing-for-overflow-scroll flag.

Created attachment 179267 [details]
Patch

[Adrienne Walker]

Comment on attachment 179267 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179267&action=review

Is this to test the positioning of overflow scroll controls? Or, just general repainting behavior?

> Tools/Scripts/webkitpy/layout_tests/port/chromium.py:399
> +            VirtualTestSuite('platform/chromium/virtual/gpu/compositedscrolling/overflow',
> +                             'compositing/overflow',
> +                             ['--enable-accelerated-compisiting-for-overflow-scroll', '--force-compisiting-mode']),
> +            VirtualTestSuite('platform/chromium/virtual/gpu/compositedscrolling/scrollbars',
> +                             'scrollbars',
> +                             ['--enable-accelerated-compisiting-for-overflow-scroll', '--force-compisiting-mode']),

Typos.

[WebKit Review Bot]

Comment on attachment 179267 [details]
Patch

Attachment 179267 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15319267

New failing tests:
platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-overlay-with-touch.html
platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-content-clip-to-viewport.html
platform/chromium/virtual/gpu/compositedscrolling/overflow/textarea-scroll-touch.html
platform/chromium/virtual/gpu/compositedscrolling/scrollbars/rtl/div-horizontal.html
platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-auto-with-touch.html
platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content.html
platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting.html
platform/chromium/virtual/gpu/compositedscrolling/scrollbars/rtl/div-absolute.html

Created attachment 179292 [details]
Patch

(In reply to comment #2)
> (From update of attachment 179267 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=179267&action=review
>
> Is this to test the positioning of overflow scroll controls? Or, just general repainting behavior?

I would like to verify this, yes, but mainly I want to ensure that when we start automatically opting into composited scrolling, that we don't introduce any unexpected regressions in these tests.

>
> > Tools/Scripts/webkitpy/layout_tests/port/chromium.py:399
> > +            VirtualTestSuite('platform/chromium/virtual/gpu/compositedscrolling/overflow',
> > +                             'compositing/overflow',
> > +                             ['--enable-accelerated-compisiting-for-overflow-scroll', '--force-compisiting-mode']),
> > +            VirtualTestSuite('platform/chromium/virtual/gpu/compositedscrolling/scrollbars',
> > +                             'scrollbars',
> > +                             ['--enable-accelerated-compisiting-for-overflow-scroll', '--force-compisiting-mode']),
>
> Typos.

Fixed.

[WebKit Review Bot]

Comment on attachment 179292 [details]
Patch

Attachment 179292 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15313354

New failing tests:
platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-overlay-with-touch.html
platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-content-clip-to-viewport.html
platform/chromium/virtual/gpu/compositedscrolling/overflow/textarea-scroll-touch.html
platform/chromium/virtual/gpu/compositedscrolling/scrollbars/rtl/div-horizontal.html
platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-auto-with-touch.html
platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content.html
platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting.html
platform/chromium/virtual/gpu/compositedscrolling/scrollbars/rtl/div-absolute.html

Created attachment 179314 [details]
Updated test expectations.

[Adrienne Walker]

Comment on attachment 179314 [details]
Updated test expectations.

What are the failures here caused by? I thought this flag didn't do anything yet.

(In reply to comment #7)
> (From update of attachment 179314 [details])
> What are the failures here caused by? I thought this flag didn't do anything yet.

The failures are due to missing test expectations. The failing tests also fail for chromium in general. I've updated the expectations file with this latest patch.

[Adrienne Walker]

Comment on attachment 179314 [details]
Updated test expectations.

Oh, right! I keep forgetting that expectations don't get inherited for virtual test suites.  R=me.

[WebKit Review Bot]

Comment on attachment 179314 [details]
Updated test expectations.

Clearing flags on attachment: 179314

Committed r137645: <http://trac.webkit.org/changeset/137645>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Dirk Pranke]

(In reply to comment #9)
> (From update of attachment 179314 [details])
> Oh, right! I keep forgetting that expectations don't get inherited for virtual test suites.  R=me.

It's probably well past time I fixed that.

[Adrienne Walker]

Reverted r137645 for reason:

Breaks some overflow layout tests

Committed r137682: <http://trac.webkit.org/changeset/137682>

[Adrienne Walker]

Comment on attachment 179314 [details]
Updated test expectations.

View in context: https://bugs.webkit.org/attachment.cgi?id=179314&action=review

> Tools/Scripts/webkitpy/layout_tests/port/chromium.py:396
> +                             ['--enable-accelerated-compositing-for-overflow-scroll']),

This should be --enable-accelerated-overflow-scroll to match Chromium.  I also think you need to add this option to DRT parsing in Tools/DumpRenderTree/chromium/DumpRenderTree.cpp.

Created attachment 179401 [details]
Patch

(In reply to comment #14)
> (From update of attachment 179314 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=179314&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/port/chromium.py:396
> > +                             ['--enable-accelerated-compositing-for-overflow-scroll']),
> 
> This should be --enable-accelerated-overflow-scroll to match Chromium.  I also think you need to add this option to DRT parsing in Tools/DumpRenderTree/chromium/DumpRenderTree.cpp.

Gah, of course! This latest patch has the correct flag, and I've confirmed that my plumbing does indeed make it in.

[WebKit Review Bot]

Comment on attachment 179401 [details]
Patch

Clearing flags on attachment: 179401

Committed r137710: <http://trac.webkit.org/changeset/137710>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.